Bug 205136 – 2.26.2: build fails

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WPE WebKit

[Tomasz Kłoczko]

make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/x86_64-redhat-linux-gnu'
make -f Source/WTF/wtf/CMakeFiles/WTF.dir/build.make Source/WTF/wtf/CMakeFiles/WTF.dir/build
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/x86_64-redhat-linux-gnu'
[  3%] Building CXX object Source/WTF/wtf/CMakeFiles/WTF.dir/URLHelpers.cpp.o
cd /home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/x86_64-redhat-linux-gnu/Source/WTF/wtf && /usr/bin/g++  -DBUILDING_WITH_CMAKE=1 -DBUILDING_WPE__=1 -DBUILDING_WTF -DBWRAP_EXECUTABLE=\"/usr/bin/bwrap\" -DDBUS_PROXY_EXECUTABLE=\"/usr/bin/xdg-dbus-proxy\" -DGETTEXT_PACKAGE=\"WPE\" -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/x86_64-redhat-linux-gnu -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/x86_64-redhat-linux-gnu/DerivedSources -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/ThirdParty -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/x86_64-redhat-linux-gnu/DerivedSources/WTF -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF/wtf -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF/wtf/dtoa -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF/wtf/persistence -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF/wtf/text -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF/wtf/text/icu -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF/wtf/threads -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF/wtf/unicode -I/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/x86_64-redhat-linux-gnu/DerivedSources/ForwardingHeaders -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include  -Wextra -Wall -Wno-expansion-to-defined -Wno-psabi -Wno-noexcept-type -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto=auto -flto-partition=none -fno-strict-aliasing -fno-exceptions -fno-rtti -DNDEBUG -fPIC   -std=c++17 -o CMakeFiles/WTF.dir/URLHelpers.cpp.o -c /home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF/wtf/URLHelpers.cpp
/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF/wtf/URLHelpers.cpp: In function ‘bool WTF::URLHelpers::allCharactersInIDNScriptWhiteList(const UChar*, int32_t)’:
/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF/wtf/URLHelpers.cpp:305:9: error: expected ‘;’ before ‘UErrorCode’
  305 |         UErrorCode error = U_ZERO_ERROR;
      |         ^~~~~~~~~~
make[2]: *** [Source/WTF/wtf/CMakeFiles/WTF.dir/build.make:950: Source/WTF/wtf/CMakeFiles/WTF.dir/URLHelpers.cpp.o] Error 1
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/x86_64-redhat-linux-gnu'
make[1]: *** [CMakeFiles/Makefile2:537: Source/WTF/wtf/CMakeFiles/WTF.dir/all] Error 2


BTW. Where is some git repo with wpewebkit?

[Carlos Alberto Lopez Perez]

(In reply to Tomasz Kłoczko from comment #0)
> /home/tkloczko/rpmbuild/BUILD/wpewebkit-2.26.2/Source/WTF/wtf/URLHelpers.cpp:
> 305:9: error: expected ‘;’ before ‘UErrorCode’
>   305 |         UErrorCode error = U_ZERO_ERROR;
>       |         ^~~~~~~~~~

This should be fixed by https://trac.webkit.org/r250747 
Try to apply that patch locally and re-build.

This patch is already marked to be included in the next stable release, so it should be fixed in 2.26.3.

> 
> BTW. Where is some git repo with wpewebkit?

Its just the WebKit repository, wpewebkit its an upstream port.
Check: https://webkit.org/getting-the-code/#checking-out-with-git

*** This bug has been marked as a duplicate of bug 202600 ***

[Tomasz Kłoczko]

OK I found the patch in git https://git.webkit.org/?p=WebKit.git;a=patch;h=730b80e691a4b9dd0e9727cfcd9806dfa542397b

And seems like it solved that issue. However not without the hickups.
That patch cannot be used unmodifird against dist tar ball because it patches not disributed Changelog files.

In that situation I see 3 solutions:
- separate commits for actual code and Changlog files
- add Changelog files to dist tar balls
- stop updatting Cahngelog files and remove them from git repo

3rd solution should be the best as git log ptovides very detailed changelog and copy/update comments in files is IMO kind of waste of tile :)

[Tomasz Kłoczko]

BTW I see a lot of changes since last tagged commit in git repo.
Do you have any plans to make next release?
It is always better to keep more and less bulky releases :)

Thanks.

[Carlos Alberto Lopez Perez]

(In reply to Tomasz Kłoczko from comment #2)
> OK I found the patch in git
> https://git.webkit.org/?p=WebKit.git;a=patch;
> h=730b80e691a4b9dd0e9727cfcd9806dfa542397b
> 
> And seems like it solved that issue. However not without the hickups.
> That patch cannot be used unmodifird against dist tar ball because it
> patches not disributed Changelog files.
> 
> In that situation I see 3 solutions:
> - separate commits for actual code and Changlog files
> - add Changelog files to dist tar balls
> - stop updatting Cahngelog files and remove them from git repo
> 
> 3rd solution should be the best as git log ptovides very detailed changelog
> and copy/update comments in files is IMO kind of waste of tile :)

WebKit development policy requires those changelog files to be generated.
Also the release tarballs don't distribute all the files of the WebKit source code base, just only the necessary ones for WPE.

What I suggest to do is simply to ignore the rejects on changelog files.

[Carlos Alberto Lopez Perez]

(In reply to Tomasz Kłoczko from comment #3)
> BTW I see a lot of changes since last tagged commit in git repo.
> Do you have any plans to make next release?
> It is always better to keep more and less bulky releases :)
> 
> Thanks.

At https://trac.webkit.org/wiki/WebKitGTK/2.26.x you can find the proposed patches to be merged for the next patch update to 2.26.

The next major stable (2.28) will be out around in some months. Check: https://wpewebkit.org/release/schedule/

[Tomasz Kłoczko]

> What I suggest to do is simply to ignore the rejects on changelog files.

Issue is that git or patch command cannot do such things automatically.
IMO if you are working in the team you should discuss that policy because it adds overhead to your work and it is kind of waster of time.
Really .. git provides all what is necessary here :)

[Carlos Alberto Lopez Perez]

(In reply to Tomasz Kłoczko from comment #6)
> > What I suggest to do is simply to ignore the rejects on changelog files.
> 
> Issue is that git or patch command cannot do such things automatically.
> IMO if you are working in the team you should discuss that policy because it
> adds overhead to your work and it is kind of waster of time.
> Really .. git provides all what is necessary here :)

Some things you likely don't know:

1) WebKit development happens on SVN, not on git. The git repository is just a mirror of the SVN.
2) The tooling for WebKit development handles merging this changelogs automatically via a 3-way merge.

If you are interested in knowing more, a good place to start reading is https://webkit.org/contributing-code/

[Tomasz Kłoczko]

Even svn provides tooling for generating changelog out of commits logs.

Git additionally makes way easier patches submission in form of PRs. Moving to giltlab or github would make all that processes even easier allowing spend more time (proportionally) on actual development.
Trying now stay away from git is like trying to kick with horse .. :)

[Carlos Alberto Lopez Perez]

(In reply to Tomasz Kłoczko from comment #8)
> Even svn provides tooling for generating changelog out of commits logs.
> 
> Git additionally makes way easier patches submission in form of PRs. Moving
> to giltlab or github would make all that processes even easier allowing
> spend more time (proportionally) on actual development.
> Trying now stay away from git is like trying to kick with horse .. :)

I would be happy if WebKit development moved to git.

But I don't have the power to take that decision.

If you want to reach the people that can make those decisions the proper place is to send a mail to [e-mail] with your suggestions.