Bug 205127 - [iOS] Issue load sooner on swipe back/forward navigation
Summary: [iOS] Issue load sooner on swipe back/forward navigation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 205087 205173
Blocks:
  Show dependency treegraph
 
Reported: 2019-12-11 10:51 PST by Chris Dumez
Modified: 2019-12-12 12:08 PST (History)
6 users (show)

See Also:


Attachments
WIP Patch (7.53 KB, patch)
2019-12-11 10:52 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (9.09 KB, patch)
2019-12-11 12:11 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-12-11 10:51:33 PST
Issue load sooner on swipe back/forward navigation on iOS. We currently wait until the end of the swipe animation to issue the load but we should be able to start loading as soon as the user lifts the finger and thus commits to navigating. This will improve perceived performance on swipe back/forward navigation.
Comment 1 Radar WebKit Bug Importer 2019-12-11 10:51:52 PST
<rdar://problem/57843862>
Comment 2 Chris Dumez 2019-12-11 10:52:20 PST
Created attachment 385409 [details]
WIP Patch
Comment 3 Chris Dumez 2019-12-11 12:11:50 PST
Created attachment 385421 [details]
Patch
Comment 4 WebKit Commit Bot 2019-12-11 14:04:23 PST
Comment on attachment 385421 [details]
Patch

Clearing flags on attachment: 385421

Committed r253394: <https://trac.webkit.org/changeset/253394>
Comment 5 WebKit Commit Bot 2019-12-11 14:04:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Truitt Savell 2019-12-12 09:41:25 PST
It looks like the changes in https://trac.webkit.org/changeset/253394/webkit

has caused swipe/basic-cached-back-swipe.html to timeout on iOS

History:
https://results.webkit.org/?suite=layout-tests&test=swipe%2Fbasic-cached-back-swipe.html
Comment 7 Chris Dumez 2019-12-12 09:47:57 PST
(In reply to Truitt Savell from comment #6)
> It looks like the changes in https://trac.webkit.org/changeset/253394/webkit
> 
> has caused swipe/basic-cached-back-swipe.html to timeout on iOS
> 
> History:
> https://results.webkit.org/?suite=layout-tests&test=swipe%2Fbasic-cached-
> back-swipe.html

Looking now.
Comment 8 Chris Dumez 2019-12-12 11:54:55 PST
(In reply to Chris Dumez from comment #7)
> (In reply to Truitt Savell from comment #6)
> > It looks like the changes in https://trac.webkit.org/changeset/253394/webkit
> > 
> > has caused swipe/basic-cached-back-swipe.html to timeout on iOS
> > 
> > History:
> > https://results.webkit.org/?suite=layout-tests&test=swipe%2Fbasic-cached-
> > back-swipe.html
> 
> Looking now.

ViewGestureController::willEndSwipeGesture() does not get called in the context on the test. We see beginSwipeGesture and then endSwipeGesture though. As a result, we do not schedule the navigation.