Bug 205122 - Python 3: Add support in webkitpy.performance_tests
Summary: Python 3: Add support in webkitpy.performance_tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-11 09:50 PST by Jonathan Bedard
Modified: 2019-12-11 13:47 PST (History)
7 users (show)

See Also:

Attachments
Patch (14.53 KB, patch)
2019-12-11 09:53 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (14.64 KB, patch)
2019-12-11 13:01 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-12-11 09:50:58 PST 
Make webkitpy.performance_tests Python 3 compatible.
Comment 1 Jonathan Bedard 2019-12-11 09:53:00 PST 
Created attachment 385404 [details]
Patch
Comment 2 Stephanie Lewis 2019-12-11 12:43:19 PST 
Comment on attachment 385404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385404&action=review

> Tools/Scripts/webkitpy/performance_tests/perftest.py:171
> +        _log.info('median= {} {}, stdev= {} {}, min= {} {}, max= {} {}'.format(

When there that many {} I prefer keywords. Makes it easier to read
Comment 3 Jonathan Bedard 2019-12-11 12:59:55 PST 
Comment on attachment 385404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385404&action=review

>> Tools/Scripts/webkitpy/performance_tests/perftest.py:171
>> +        _log.info('median= {} {}, stdev= {} {}, min= {} {}, max= {} {}'.format(
> 
> When there that many {} I prefer keywords. Makes it easier to read

Good idea, makes this much more reasonable.
Comment 4 Jonathan Bedard 2019-12-11 13:01:16 PST 
Created attachment 385426 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-12-11 13:46:03 PST 
Comment on attachment 385426 [details]
Patch for landing

Clearing flags on attachment: 385426

Committed r253392: <https://trac.webkit.org/changeset/253392>
Comment 6 WebKit Commit Bot 2019-12-11 13:46:05 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-11 13:47:18 PST 
<rdar://problem/57851823>