Bug 205115 - [LFC][IFC] Fix fast/text/hyphenate-limit-lines.html
Summary: [LFC][IFC] Fix fast/text/hyphenate-limit-lines.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-11 08:08 PST by zalan
Modified: 2019-12-11 08:45 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.22 KB, patch)
2019-12-11 08:16 PST, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-12-11 08:08:27 PST 
handle the hyphenated line count properly
Comment 1 Radar WebKit Bug Importer 2019-12-11 08:08:50 PST 
<rdar://problem/57837829>
Comment 2 zalan 2019-12-11 08:16:19 PST 
Created attachment 385393 [details]
Patch
Comment 3 Antti Koivisto 2019-12-11 08:23:03 PST 
Comment on attachment 385393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385393&action=review

> Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:246
> +        m_successiveHyphenatedLineCount = breakingContext.partialTrailingContent && breakingContext.partialTrailingContent->needsHyphen ? m_successiveHyphenatedLineCount + 1 : 0;

Might read better as if()
Comment 4 Antti Koivisto 2019-12-11 08:24:05 PST 
if()
  ++m_successiveHyphenatedLineCount;
else
  m_successiveHyphenatedLineCount = 0;
Comment 5 zalan 2019-12-11 08:36:09 PST 
Committed r253373: <https://trac.webkit.org/changeset/253373>
Comment 6 zalan 2019-12-11 08:45:57 PST 
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 385393 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385393&action=review
> 
> > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:246
> > +        m_successiveHyphenatedLineCount = breakingContext.partialTrailingContent && breakingContext.partialTrailingContent->needsHyphen ? m_successiveHyphenatedLineCount + 1 : 0;
> 
> Might read better as if()
good point!