Bug 205108 - [JSC] Lock-down JSGlobalObject and derived classes in IsoSubspace
Summary: [JSC] Lock-down JSGlobalObject and derived classes in IsoSubspace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-11 03:19 PST by Yusuke Suzuki
Modified: 2019-12-12 13:34 PST (History)
16 users (show)

See Also:

Attachments
Patch (34.05 KB, patch)
2019-12-11 03:23 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (40.35 KB, patch)
2019-12-11 03:43 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (96.27 KB, patch)
2019-12-11 03:54 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (99.56 KB, patch)
2019-12-11 04:07 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (99.66 KB, patch)
2019-12-11 04:22 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (99.67 KB, patch)
2019-12-11 04:33 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Patch (104.67 KB, patch)
2019-12-11 15:10 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (104.71 KB, patch)
2019-12-11 15:24 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (105.59 KB, patch)
2019-12-12 03:15 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (106.88 KB, patch)
2019-12-12 03:33 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-12-11 03:19:51 PST 
...
Comment 1 Yusuke Suzuki 2019-12-11 03:23:10 PST 
Created attachment 385372 [details]
Patch
Comment 2 Yusuke Suzuki 2019-12-11 03:43:16 PST 
Created attachment 385376 [details]
Patch
Comment 3 Yusuke Suzuki 2019-12-11 03:54:17 PST 
Created attachment 385377 [details]
Patch
Comment 4 Yusuke Suzuki 2019-12-11 04:07:45 PST 
Created attachment 385379 [details]
Patch
Comment 5 Yusuke Suzuki 2019-12-11 04:22:15 PST 
Created attachment 385380 [details]
Patch
Comment 6 Yusuke Suzuki 2019-12-11 04:33:12 PST 
Created attachment 385381 [details]
Patch
Comment 7 Mark Lam 2019-12-11 09:17:46 PST 
Comment on attachment 385381 [details]
Patch

r=me.

Please fix the win bots failure (probably just need a JS_EXPORT_PRIVATE attribute on 2 functions according to wincairo bot).  The jsc EWS says testapi is failing.  Looks legit.  Please fix before landing.
Comment 8 Yusuke Suzuki 2019-12-11 14:20:32 PST 
(In reply to Mark Lam from comment #7)
> Comment on attachment 385381 [details]
> Patch
> 
> r=me.
> 
> Please fix the win bots failure (probably just need a JS_EXPORT_PRIVATE
> attribute on 2 functions according to wincairo bot).  The jsc EWS says
> testapi is failing.  Looks legit.  Please fix before landing.

Yeah, right. Annotated, and fixed the testapi.
Comment 9 Yusuke Suzuki 2019-12-11 15:10:37 PST 
Created attachment 385446 [details]
Patch

Patch for landing
Comment 10 Yusuke Suzuki 2019-12-11 15:24:01 PST 
Created attachment 385448 [details]
Patch

Patch for landing
Comment 11 Yusuke Suzuki 2019-12-12 03:15:47 PST 
Created attachment 385487 [details]
Patch

Patch for landing
Comment 12 Yusuke Suzuki 2019-12-12 03:33:53 PST 
Created attachment 385488 [details]
Patch

Patch for landing
Comment 13 Yusuke Suzuki 2019-12-12 13:34:00 PST 
Committed r253443: <https://trac.webkit.org/changeset/253443>
Comment 14 Radar WebKit Bug Importer 2019-12-12 13:34:24 PST 
<rdar://problem/57889778>