Bug 205102 - Web Inspector: REGRESSION: Console: unable to switch execution contexts
Summary: Web Inspector: REGRESSION: Console: unable to switch execution contexts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-10 21:50 PST by Devin Rousso
Modified: 2019-12-11 17:39 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.75 KB, patch)
2019-12-10 21:51 PST, Devin Rousso
bburg: review+
bburg: commit-queue-
Details | Formatted Diff | Diff
Patch (5.74 KB, patch)
2019-12-11 16:54 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-12-10 21:50:15 PST
# STEPS TO REPRODUCE:
1. inspect any page with an `<iframe>`
2. attempt to switch execution contexts in the left of the Console prompt
 => clicking on the "Auto - ..." text doesn't do anything
Comment 1 Devin Rousso 2019-12-10 21:50:24 PST
<rdar://problem/57748393>
Comment 2 Devin Rousso 2019-12-10 21:51:14 PST
Created attachment 385345 [details]
Patch
Comment 3 Blaze Burg 2019-12-11 15:42:16 PST
Comment on attachment 385345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385345&action=review

r=me

> Source/WebInspectorUI/ChangeLog:25
> +        When the execution context of the main frame changes, recreate the main exexution context

Nit: 'execution'
Comment 4 Devin Rousso 2019-12-11 16:54:48 PST
Created attachment 385460 [details]
Patch

Stusid exexution concexts T.T
Comment 5 WebKit Commit Bot 2019-12-11 17:39:04 PST
Comment on attachment 385460 [details]
Patch

Clearing flags on attachment: 385460

Committed r253411: <https://trac.webkit.org/changeset/253411>
Comment 6 WebKit Commit Bot 2019-12-11 17:39:06 PST
All reviewed patches have been landed.  Closing bug.