RESOLVED FIXED 205097
[JSC] Put all API related JS cells into IsoSubspace 
https://bugs.webkit.org/show_bug.cgi?id=205097
Summary [JSC] Put all API related JS cells into IsoSubspace
Yusuke Suzuki
Reported 2019-12-10 20:41:01 PST
[JSC] Put all API related JS cells into IsoSubspace
Attachments
Patch (32.79 KB, patch)
2019-12-10 20:41 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (36.29 KB, patch)
2019-12-10 21:23 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (36.28 KB, patch)
2019-12-10 21:26 PST, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
Patch (36.29 KB, patch)
2019-12-10 21:52 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (35.77 KB, patch)
2019-12-10 22:12 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (35.86 KB, patch)
2019-12-10 22:45 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (36.29 KB, patch)
2019-12-10 23:07 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (36.36 KB, patch)
2019-12-11 01:32 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (38.07 KB, patch)
2019-12-11 01:35 PST, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-12-10 20:41:39 PST
Created attachment 385339 [details] Patch
Yusuke Suzuki
Comment 2 2019-12-10 21:23:04 PST
Created attachment 385340 [details] Patch
Yusuke Suzuki
Comment 3 2019-12-10 21:26:43 PST
Created attachment 385341 [details] Patch
Mark Lam
Comment 4 2019-12-10 21:46:21 PST
Comment on attachment 385341 [details] Patch r=me. Please fix the failures reported by the wpe and jsc-i386 bots if possible before landing. It looks like failure is because they are building JSAPIGlobalObject.cpp. I wonder why given it's not relevant for those platforms.
Yusuke Suzuki
Comment 5 2019-12-10 21:50:56 PST
(In reply to Mark Lam from comment #4) > Comment on attachment 385341 [details] > Patch > > r=me. Please fix the failures reported by the wpe and jsc-i386 bots if > possible before landing. It looks like failure is because they are building > JSAPIGlobalObject.cpp. I wonder why given it's not relevant for those > platforms. Thanks, yeah. I'll fix it.
Yusuke Suzuki
Comment 6 2019-12-10 21:52:34 PST
Created attachment 385347 [details] Patch Patch for landing
Yusuke Suzuki
Comment 7 2019-12-10 22:12:46 PST
Created attachment 385349 [details] Patch Patch for landing
Yusuke Suzuki
Comment 8 2019-12-10 22:45:01 PST
Created attachment 385352 [details] Patch Patch for landing
Yusuke Suzuki
Comment 9 2019-12-10 23:07:10 PST
Created attachment 385356 [details] Patch Patch for landing
Yusuke Suzuki
Comment 10 2019-12-11 01:32:37 PST
Created attachment 385363 [details] Patch Patch for landing
Yusuke Suzuki
Comment 11 2019-12-11 01:35:20 PST
Created attachment 385364 [details] Patch Patch for landing
Yusuke Suzuki
Comment 12 2019-12-11 01:48:05 PST
Committed r253365: <https://trac.webkit.org/changeset/253365>
Radar WebKit Bug Importer
Comment 13 2019-12-11 01:49:21 PST
<rdar://problem/57828262>
Note You need to log in before you can comment on or make changes to this bug.