Bug 205095 – IndexedDB: Introduce WebIDBServer class

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sihui Liu]

We have InProcessIDBServer in WebKitLegacy, now we create WebIDBServer which owns IDBServer in WebKit. This is a step to https://bugs.webkit.org/show_bug.cgi?id=203690.

[Sihui Liu]

Created attachment 385322 [details]
Patch

[Sihui Liu]

Created attachment 385323 [details]
Patch

[Sihui Liu]

Created attachment 385325 [details]
Patch

[Sihui Liu]

Created attachment 385397 [details]
Patch

[Alex Christensen]

Comment on attachment 385397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385397&action=review

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:90
> +    RefPtr<WebCore::IDBServer::IDBServer> m_server;

This could be a Ref.

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:91
> +    bool m_isSuspended { false };

This could be wrapped in #if !ASSERT_DISABLED
Not too important, though.

[Sihui Liu]

(In reply to Alex Christensen from comment #5)
> Comment on attachment 385397 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385397&action=review
> 
> > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:90
> > +    RefPtr<WebCore::IDBServer::IDBServer> m_server;
> 
> This could be a Ref.

Sure.

>
> > Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:91
> > +    bool m_isSuspended { false };
> 
> This could be wrapped in #if !ASSERT_DISABLED
> Not too important, though.

I was meant to use this for early return in WebIDBServer::suspend. Will add that!

[Sihui Liu]

Created attachment 385407 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 385407 [details]
Patch

Clearing flags on attachment: 385407

Committed r253393: <https://trac.webkit.org/changeset/253393>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57851867>