Bug 205092 – [Bindings] Cross-origin checks happen too late for overloaded methods

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Cross-origin checks happen too late for overloaded methods. We're supposed to do the security check and then find the right overload to call [1]. In our bindings, we first find the right overload body to call and then do the security check in the body of the chosen overload. This results in the wrong exception being thrown in some cases.

[1] https://heycam.github.io/webidl/#dfn-create-operation-function

[Chris Dumez]

Created attachment 385317 [details]
Patch

[Sam Weinig]

Nice catch. Do the bindings tests (run-bindings-tests) output change?

[Chris Dumez]

(In reply to Sam Weinig from comment #2)
> Nice catch. Do the bindings tests (run-bindings-tests) output change?

They do not, the bindings bubble is green.

[Chris Dumez]

(In reply to Chris Dumez from comment #3)
> (In reply to Sam Weinig from comment #2)
> > Nice catch. Do the bindings tests (run-bindings-tests) output change?
> 
> They do not, the bindings bubble is green.

Will look into adding test coverage. Looks like there is an EWS failure to investigate too.

[Sam Weinig]

(In reply to Chris Dumez from comment #3)
> (In reply to Sam Weinig from comment #2)
> > Nice catch. Do the bindings tests (run-bindings-tests) output change?
> 
> They do not, the bindings bubble is green.

In that case, mind adding an overload that triggers this to the bindings tests? Seeing the new generated code can help make the reviewing easier (and more tests seem good).

[Chris Dumez]

Created attachment 385335 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 385335 [details]
Patch

Clearing flags on attachment: 385335

Committed r253381: <https://trac.webkit.org/changeset/253381>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57844610>