Bug 205066 - [GStreamer][MediaStream] Fix GStreamer capturer mock
Summary: [GStreamer][MediaStream] Fix GStreamer capturer mock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
: 199440 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-12-10 09:44 PST by Thibault Saunier
Modified: 2019-12-12 09:50 PST (History)
16 users (show)

See Also:

Attachments
Patch (12.13 KB, patch)
2019-12-10 10:24 PST, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch (11.52 KB, patch)
2019-12-10 13:11 PST, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Patch (11.52 KB, patch)
2019-12-11 04:02 PST, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2019-12-10 09:44:24 PST 
- Presets where wrongly generated based on GStreamer capabilities
- Audio capturer was not taking into account echo cancellation
Comment 1 Thibault Saunier 2019-12-10 10:24:43 PST 
Created attachment 385282 [details]
Patch
Comment 2 Philippe Normand 2019-12-10 10:37:03 PST 
EWS is red. Patch needs a rebase it seems.
Comment 3 Thibault Saunier 2019-12-10 13:11:44 PST 
Created attachment 385300 [details]
Patch
Comment 4 Philippe Normand 2019-12-10 13:22:40 PST 
*** Bug 199440 has been marked as a duplicate of this bug. ***
Comment 5 Thibault Saunier 2019-12-11 04:02:52 PST 
Created attachment 385378 [details]
Patch
Comment 6 Philippe Normand 2019-12-11 04:22:42 PST 
So what changed here since I r+'ed?
Comment 7 Thibault Saunier 2019-12-11 05:18:39 PST 
(In reply to Philippe Normand from comment #6)
> So what changed here since I r+'ed?

Nothing, but the CI failed and I had to make it run again, in that case how could I avoided to loose the r+?
Comment 8 Philippe Normand 2019-12-11 05:21:08 PST 
Add the "Reviewed by..." in the ChangeLog and re-upload the patch asking only for "cq?" :)
Comment 9 WebKit Commit Bot 2019-12-11 06:04:56 PST 
Comment on attachment 385378 [details]
Patch

Clearing flags on attachment: 385378

Committed r253368: <https://trac.webkit.org/changeset/253368>
Comment 10 WebKit Commit Bot 2019-12-11 06:04:58 PST 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-12-11 06:05:28 PST 
<rdar://problem/57834421>