Bug 205056 - Add support for Audio Capture in GPUProcess
Summary: Add support for Audio Capture in GPUProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 205328
Blocks:
  Show dependency treegraph
 
Reported: 2019-12-10 03:42 PST by youenn fablet
Modified: 2019-12-20 03:48 PST (History)
13 users (show)

See Also:


Attachments
Patch (30.07 KB, patch)
2019-12-10 04:35 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (41.77 KB, patch)
2019-12-17 06:13 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (41.79 KB, patch)
2019-12-17 06:34 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (41.50 KB, patch)
2019-12-18 08:29 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-12-10 03:42:08 PST
Add support for Audio Capture in GPUProcess
Comment 1 youenn fablet 2019-12-10 04:35:53 PST
Created attachment 385249 [details]
Patch
Comment 2 youenn fablet 2019-12-17 06:13:35 PST
Created attachment 385880 [details]
Patch
Comment 3 Eric Carlson 2019-12-17 06:20:13 PST
Comment on attachment 385880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385880&action=review

> Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:96
> +    if (m_disableAudioSessionCheck) {

Do you mean "if (!m_disableAudioSessionCheck)" ?
Comment 4 youenn fablet 2019-12-17 06:21:42 PST
(In reply to Eric Carlson from comment #3)
> Comment on attachment 385880 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385880&action=review
> 
> > Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:96
> > +    if (m_disableAudioSessionCheck) {
> 
> Do you mean "if (!m_disableAudioSessionCheck)" ?

Right!
Comment 5 youenn fablet 2019-12-17 06:22:18 PST
(In reply to youenn fablet from comment #4)
> (In reply to Eric Carlson from comment #3)
> > Comment on attachment 385880 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=385880&action=review
> > 
> > > Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp:96
> > > +    if (m_disableAudioSessionCheck) {
> > 
> > Do you mean "if (!m_disableAudioSessionCheck)" ?
> 
> Right!

Need to hook in WTR crash reports with the GPU process.
Comment 6 youenn fablet 2019-12-17 06:34:13 PST
Created attachment 385882 [details]
Patch
Comment 7 Eric Carlson 2019-12-17 11:03:24 PST
Comment on attachment 385882 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385882&action=review

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:80
> +    , m_userMediaCaptureManagerProxy(makeUnique<UserMediaCaptureManagerProxy>(makeUniqueRef<GPUProxyForCapture>(*this)))

Can we allocate this lazily?
Comment 8 youenn fablet 2019-12-18 08:29:30 PST
Created attachment 385977 [details]
Patch for landing
Comment 9 youenn fablet 2019-12-18 08:29:56 PST
(In reply to Eric Carlson from comment #7)
> Comment on attachment 385882 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385882&action=review
> 
> > Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:80
> > +    , m_userMediaCaptureManagerProxy(makeUnique<UserMediaCaptureManagerProxy>(makeUniqueRef<GPUProxyForCapture>(*this)))
> 
> Can we allocate this lazily?

Done, thanks!
Comment 10 WebKit Commit Bot 2019-12-18 11:40:15 PST
Comment on attachment 385977 [details]
Patch for landing

Clearing flags on attachment: 385977

Committed r253705: <https://trac.webkit.org/changeset/253705>
Comment 11 WebKit Commit Bot 2019-12-18 11:40:17 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2019-12-18 11:43:01 PST
<rdar://problem/58051486>
Comment 13 Truitt Savell 2019-12-19 08:58:19 PST
Looks like the changes in https://trac.webkit.org/changeset/253705/webkit
brok a test, tracking in https://bugs.webkit.org/show_bug.cgi?id=205455
Comment 14 youenn fablet 2019-12-20 03:48:27 PST
(In reply to Truitt Savell from comment #13)
> Looks like the changes in https://trac.webkit.org/changeset/253705/webkit
> brok a test, tracking in https://bugs.webkit.org/show_bug.cgi?id=205455

Will be fixed by https://bugs.webkit.org/show_bug.cgi?id=205492