Bug 205049 - [JSC] Put JSArray in IsoSubspace
Summary: [JSC] Put JSArray in IsoSubspace
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 205084
Blocks:
  Show dependency tree / graph
 
Reported: 2019-12-09 20:19 PST by Yusuke Suzuki
Modified: 2019-12-10 13:51 PST (History)
8 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2019-12-09 20:20 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (3.43 KB, patch)
2019-12-09 20:20 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (10.83 KB, patch)
2019-12-09 20:29 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (10.85 KB, patch)
2019-12-09 20:32 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Patch (10.85 KB, patch)
2019-12-09 21:07 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (11.09 KB, patch)
2019-12-10 00:54 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-12-09 20:19:46 PST 
[JSC] Put JSArray in IsoSubspace
Comment 1 Yusuke Suzuki 2019-12-09 20:20:05 PST 
Created attachment 385232 [details]
Patch
Comment 2 Yusuke Suzuki 2019-12-09 20:20:57 PST 
Created attachment 385233 [details]
Patch
Comment 3 Yusuke Suzuki 2019-12-09 20:29:18 PST 
Created attachment 385234 [details]
Patch
Comment 4 Yusuke Suzuki 2019-12-09 20:32:48 PST 
Created attachment 385235 [details]
Patch
Comment 5 Mark Lam 2019-12-09 20:38:06 PST 
Comment on attachment 385235 [details]
Patch

r=me
Comment 6 Mark Lam 2019-12-09 20:53:08 PST 
Comment on attachment 385235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385235&action=review

> Source/JavaScriptCore/tools/JSDollarVM.cpp:501
> +    CompleteSubspace* subspaceFor(VM& vm)

Need to be static?
Comment 7 Yusuke Suzuki 2019-12-09 21:07:38 PST 
Created attachment 385238 [details]
Patch

Patch for landing
Comment 8 Yusuke Suzuki 2019-12-10 00:54:58 PST 
Created attachment 385243 [details]
Patch

Patch for landing
Comment 9 Yusuke Suzuki 2019-12-10 01:41:41 PST 
Committed r253321: <https://trac.webkit.org/changeset/253321>
Comment 10 Radar WebKit Bug Importer 2019-12-10 01:42:45 PST 
<rdar://problem/57786796>
Comment 11 WebKit Commit Bot 2019-12-10 13:51:55 PST 
Re-opened since this is blocked by bug 205084