Bug 205039 – Web Inspector: Elements: Styles: hovering over an invalid value while holding ⌘ doesn't change the color of the text

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Normally, when hovering over any name/value while holding ⌘, the text turns blue and an underline appears, meaning that when the hovered text is clicked, the user is taken to the source code location for that text in the Sources Tab.

When hovering an invalid value, however, this coloration doesn't happen.

```
    color: "this should fail";
```

[Devin Rousso]

Created attachment 385212 [details]
Patch

[Blaze Burg]

Comment on attachment 385212 [details]
Patch

r=me
It still seems a bit wonky if you hover a property value and then press command. In that case, not all of the other properties and values in the section get the underlining until mouse hover leaves and re-enters the entire section. But this part is not a regression. Can you see if you are able to repro that behavior?

[Devin Rousso]

Created attachment 385343 [details]
Patch

(In reply to Brian Burg from comment #2)
> It still seems a bit wonky if you hover a property value and then press command. In that case, not all of the other properties and values in the section get the underlining until mouse hover leaves and re-enters the entire section. But this part is not a regression. Can you see if you are able to repro that behavior?
I was able to reproduce the behavior as you describe, and I think I was able to fix it by being more specific as to when we apply _any_ CSS rule that involves color.

[Devin Rousso]

Created attachment 385350 [details]
Patch

[Blaze Burg]

Comment on attachment 385350 [details]
Patch

r=me

Works much better now, thank you!

[WebKit Commit Bot]

Comment on attachment 385350 [details]
Patch

Clearing flags on attachment: 385350

Committed r253405: <https://trac.webkit.org/changeset/253405>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57859655>