REGRESSION(r252523): Web Inspector: Styles: semicolon is wrongly positioned in multiline values

[Nikita Vasilyev]

Created attachment 385203 [details]
[image] Bug

The semicolon should immediately follow the last character of the value.

[Radar WebKit Bug Importer]

<rdar://problem/57772846>

[Devin Rousso]

Created attachment 385211 [details]
Patch

[Nikita Vasilyev]

Comment on attachment 385211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385211&action=review

This fixes the bug.

> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:186
> -        this._valueElement = this._contentElement.appendChild(document.createElement("span"));
> +        let valueContainer = this._contentElement.appendChild(document.createElement("span"));
> +        valueContainer.className = "value-container";
> +
> +        this._valueElement = valueContainer.appendChild(document.createElement("span"));

This looks fine — I don't know how to resolve this without introducing the wrapper element ("value-container").

[BJ Burg]

Comment on attachment 385211 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 385211 [details]
Patch

Clearing flags on attachment: 385211

Committed r253338: <https://trac.webkit.org/changeset/253338>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.