Bug 205032 - Make incremental builds faster after modifying DisplayListItems.h
Summary: Make incremental builds faster after modifying DisplayListItems.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2019-12-09 16:03 PST by Wenson Hsieh
Modified: 2019-12-11 11:08 PST (History)
9 users (show)

See Also:

Attachments
Depends on webkit.org/b/204955 (11.88 KB, patch)
2019-12-09 16:11 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (11.25 KB, patch)
2019-12-11 08:07 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (11.77 KB, patch)
2019-12-11 08:22 PST, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
For EWS (9.75 KB, patch)
2019-12-11 09:22 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-12-09 16:03:52 PST 
Touching DisplayListItems.h (typically for the purposes of adding or adjusting encoding/decoding logic) currently dirties DisplayList.h, which goes on to dirty a handful of other files in WebCore (which could grow in number in the near future).

Move a bit of logic around to minimize the number of files that need to be recompiled as a result of modifying this header.
Comment 1 Wenson Hsieh 2019-12-09 16:11:52 PST Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2019-12-11 08:07:15 PST Comment hidden (obsolete)
Comment 3 Wenson Hsieh 2019-12-11 08:22:22 PST Comment hidden (obsolete)
Comment 4 Tim Horton 2019-12-11 08:44:36 PST 
Comment on attachment 385394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385394&action=review

> Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:-159
> -class DrawingItem : public Item {

Does DL.h actually need drawing item or just item?
Comment 5 Wenson Hsieh 2019-12-11 09:19:41 PST 
Comment on attachment 385394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385394&action=review

>> Source/WebCore/platform/graphics/displaylists/DisplayListItems.h:-159
>> -class DrawingItem : public Item {
> 
> Does DL.h actually need drawing item or just item?

Oh good point — it just needs DisplayList::Item, not DisplayList::DrawingItem. I moved DrawingItem back into DisplayListItems.h.
Comment 6 Wenson Hsieh 2019-12-11 09:22:57 PST 
Created attachment 385401 [details]
For EWS
Comment 7 WebKit Commit Bot 2019-12-11 10:42:32 PST 
Comment on attachment 385401 [details]
For EWS

Clearing flags on attachment: 385401

Committed r253380: <https://trac.webkit.org/changeset/253380>