Bug 205028 - [WK2][iOS] Visibility propagation view is not properly updated when navigating cross-process
Summary: [WK2][iOS] Visibility propagation view is not properly updated when navigatin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-09 14:49 PST by Chris Dumez
Modified: 2019-12-10 15:59 PST (History)
7 users (show)

See Also:

Attachments
Patch (14.58 KB, patch)
2019-12-09 15:50 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.67 KB, patch)
2019-12-09 16:00 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-12-09 14:49:12 PST 
Visibility propagation view is not properly updated when navigating cross-process on iOS WK2.
Comment 1 Chris Dumez 2019-12-09 15:50:19 PST 
Created attachment 385193 [details]
Patch
Comment 2 Chris Dumez 2019-12-09 16:00:15 PST 
Created attachment 385198 [details]
Patch
Comment 3 Tim Horton 2019-12-10 11:47:22 PST 
Comment on attachment 385198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385198&action=review

> Source/WebKit/UIProcess/SuspendedPageProxy.h:50
> +using LayerHostingContextID = uint32_t;

Odd that we have this in so many places
Comment 4 Chris Dumez 2019-12-10 12:04:16 PST 
Comment on attachment 385198 [details]
Patch

Clearing flags on attachment: 385198

Committed r253337: <https://trac.webkit.org/changeset/253337>
Comment 5 Chris Dumez 2019-12-10 12:04:18 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-12-10 12:06:21 PST 
<rdar://problem/57803133>
Comment 7 Truitt Savell 2019-12-10 15:41:36 PST 
It looks like the changes in https://trac.webkit.org/changeset/253337/webkit

caused testing to exit early on Mac Debug wk2

Build:
https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/6312

I was able to reproduce this on 253337 but not 253336 by just running the http/tests/ directory.
Comment 8 Chris Dumez 2019-12-10 15:59:53 PST 
(In reply to Truitt Savell from comment #7)
> It looks like the changes in https://trac.webkit.org/changeset/253337/webkit
> 
> caused testing to exit early on Mac Debug wk2
> 
> Build:
> https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/
> builds/6312
> 
> I was able to reproduce this on 253337 but not 253336 by just running the
> http/tests/ directory.

Follow-up in <https://trac.webkit.org/changeset/253354>.