Bug 205018 - Finish encoding/decoding support for DisplayList::SetState
Summary: Finish encoding/decoding support for DisplayList::SetState
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-09 10:11 PST by Wenson Hsieh
Modified: 2019-12-09 14:54 PST (History)
7 users (show)

See Also:

Attachments
WIP for EWS (34.89 KB, patch)
2019-12-09 11:06 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix GTK/WPE & rebaseline a test (36.12 KB, patch)
2019-12-09 12:05 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Rebaseline more tests (37.55 KB, patch)
2019-12-09 12:53 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-12-09 10:11:29 PST 
Many fields are currently not being encoded/decoded in SetState.
Comment 1 Wenson Hsieh 2019-12-09 11:06:54 PST 
Created attachment 385170 [details]
WIP for EWS
Comment 2 Tim Horton 2019-12-09 11:16:08 PST 
Comment on attachment 385170 [details]
WIP for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=385170&action=review

> Source/WebCore/ChangeLog:27
> +        Remove ShadowColorChange, which was unused; instead, shadow color changes are indicated by the ShadowChange
> +        flag, which also encompasses shadow offset and blur.

Weird, wonder what that was for
Comment 3 Wenson Hsieh 2019-12-09 12:04:10 PST 
Comment on attachment 385170 [details]
WIP for EWS

View in context: https://bugs.webkit.org/attachment.cgi?id=385170&action=review

(It looks like I have a test to rebaseline after changing the Change flags).

>> Source/WebCore/ChangeLog:27
>> +        flag, which also encompasses shadow offset and blur.
> 
> Weird, wonder what that was for

Unsure! It looks like this was added several years ago in r194708, but was, AFAICT, unused. Changes in shadow color were instead flagged using ShadowChange.
Comment 4 Wenson Hsieh 2019-12-09 12:05:59 PST Comment hidden (obsolete)
Comment 5 Wenson Hsieh 2019-12-09 12:53:35 PST 
Created attachment 385180 [details]
Rebaseline more tests
Comment 6 WebKit Commit Bot 2019-12-09 14:53:34 PST 
Comment on attachment 385180 [details]
Rebaseline more tests

Clearing flags on attachment: 385180

Committed r253302: <https://trac.webkit.org/changeset/253302>
Comment 7 WebKit Commit Bot 2019-12-09 14:53:36 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-12-09 14:54:48 PST 
<rdar://problem/57769821>