Bug 205012 - Regression(r249329) ViewGestureController::requestRenderTreeSizeNotificationIfNeeded() sometimes uses wrong webPageID for IPC
Summary: Regression(r249329) ViewGestureController::requestRenderTreeSizeNotificationI...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
: 202568 (view as bug list)
Depends on:
Blocks: 201225
  Show dependency treegraph
 
Reported: 2019-12-09 08:53 PST by Chris Dumez
Modified: 2019-12-30 12:41 PST (History)
7 users (show)

See Also:


Attachments
Patch (15.75 KB, patch)
2019-12-09 09:09 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (15.31 KB, patch)
2019-12-09 09:18 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (15.81 KB, patch)
2019-12-09 13:21 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (16.26 KB, patch)
2019-12-09 13:59 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (16.26 KB, patch)
2019-12-09 14:00 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-12-09 08:53:56 PST
Since r249329, ViewGestureController::requestRenderTreeSizeNotificationIfNeeded() uses the wrong webPageID for IPC when the navigation swaps process.
Comment 1 Chris Dumez 2019-12-09 09:09:54 PST
Created attachment 385157 [details]
Patch
Comment 2 Chris Dumez 2019-12-09 09:18:10 PST
Created attachment 385158 [details]
Patch
Comment 3 Tim Horton 2019-12-09 10:38:31 PST
Comment on attachment 385158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385158&action=review

> Source/WebKit/UIProcess/ViewGestureController.cpp:614
> +    messageSender->send(Messages::ViewGestureGeometryCollector::SetRenderTreeSizeNotificationThreshold(threshold));

Kinda sad VGC needs to know about provisional pages at all.
Comment 4 Chris Dumez 2019-12-09 11:04:18 PST
(In reply to Tim Horton from comment #3)
> Comment on attachment 385158 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385158&action=review
> 
> > Source/WebKit/UIProcess/ViewGestureController.cpp:614
> > +    messageSender->send(Messages::ViewGestureGeometryCollector::SetRenderTreeSizeNotificationThreshold(threshold));
> 
> Kinda sad VGC needs to know about provisional pages at all.

Agreed, will look into doing this better in a follow-up.
Comment 5 Chris Dumez 2019-12-09 13:21:20 PST
Created attachment 385181 [details]
Patch
Comment 6 Chris Dumez 2019-12-09 13:59:43 PST
Created attachment 385187 [details]
Patch
Comment 7 Chris Dumez 2019-12-09 14:00:40 PST
Created attachment 385188 [details]
Patch
Comment 8 WebKit Commit Bot 2019-12-09 15:40:03 PST
Comment on attachment 385188 [details]
Patch

Clearing flags on attachment: 385188

Committed r253304: <https://trac.webkit.org/changeset/253304>
Comment 9 WebKit Commit Bot 2019-12-09 15:40:05 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2019-12-09 15:41:45 PST
<rdar://problem/57771723>
Comment 11 Alice Mikhaylenko 2019-12-30 12:41:56 PST
*** Bug 202568 has been marked as a duplicate of this bug. ***