Bug 205012 – Regression(r249329) ViewGestureController::requestRenderTreeSizeNotificationIfNeeded() sometimes uses wrong webPageID for IPC

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Since r249329, ViewGestureController::requestRenderTreeSizeNotificationIfNeeded() uses the wrong webPageID for IPC when the navigation swaps process.

[Chris Dumez]

Created attachment 385157 [details]
Patch

[Chris Dumez]

Created attachment 385158 [details]
Patch

[Tim Horton]

Comment on attachment 385158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385158&action=review

> Source/WebKit/UIProcess/ViewGestureController.cpp:614
> +    messageSender->send(Messages::ViewGestureGeometryCollector::SetRenderTreeSizeNotificationThreshold(threshold));

Kinda sad VGC needs to know about provisional pages at all.

[Chris Dumez]

(In reply to Tim Horton from comment #3)
> Comment on attachment 385158 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385158&action=review
> 
> > Source/WebKit/UIProcess/ViewGestureController.cpp:614
> > +    messageSender->send(Messages::ViewGestureGeometryCollector::SetRenderTreeSizeNotificationThreshold(threshold));
> 
> Kinda sad VGC needs to know about provisional pages at all.

Agreed, will look into doing this better in a follow-up.

[Chris Dumez]

Created attachment 385181 [details]
Patch

[Chris Dumez]

Created attachment 385187 [details]
Patch

[Chris Dumez]

Created attachment 385188 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 385188 [details]
Patch

Clearing flags on attachment: 385188

Committed r253304: <https://trac.webkit.org/changeset/253304>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57771723>

[Alice Mikhaylenko]

*** Bug 202568 has been marked as a duplicate of this bug. ***