Bug 204993 - Move WebCore::Path encoders and decoders into WebCore from WebCoreArgumentCoders
Summary: Move WebCore::Path encoders and decoders into WebCore from WebCoreArgumentCoders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-07 17:05 PST by Wenson Hsieh
Modified: 2019-12-08 13:39 PST (History)
6 users (show)

See Also:

Attachments
Patch (22.45 KB, patch)
2019-12-07 19:01 PST, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (21.95 KB, patch)
2019-12-08 12:46 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2019-12-07 17:05:40 PST 
Other logic in WebCore needs to know about Path encoding/decoding, so it makes more sense to move the logic here.
Comment 1 Wenson Hsieh 2019-12-07 19:01:54 PST 
Created attachment 385111 [details]
Patch
Comment 2 Tim Horton 2019-12-08 01:21:24 PST 
Comment on attachment 385111 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385111&action=review

> Source/WebCore/platform/graphics/Path.h:242
> +        case PathElementMoveToPoint: // The points member will contain 1 value.

These comments seem a bit silly
Comment 3 Wenson Hsieh 2019-12-08 12:34:35 PST 
Comment on attachment 385111 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385111&action=review

>> Source/WebCore/platform/graphics/Path.h:242
>> +        case PathElementMoveToPoint: // The points member will contain 1 value.
> 
> These comments seem a bit silly

Will remove these inline comments (and the matching ones in the decoder below).
Comment 4 Wenson Hsieh 2019-12-08 12:46:04 PST 
Created attachment 385126 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-12-08 13:31:23 PST 
Comment on attachment 385126 [details]
Patch for landing

Clearing flags on attachment: 385126

Committed r253278: <https://trac.webkit.org/changeset/253278>
Comment 6 Radar WebKit Bug Importer 2019-12-08 13:39:26 PST 
<rdar://problem/57735936>