RESOLVED FIXED204991
[LFC][IFC] Convert InlineLayoutUnit/Point/Rect to LayoutUnit/Point/Rect when crossing inline/block boundary
https://bugs.webkit.org/show_bug.cgi?id=204991
Summary [LFC][IFC] Convert InlineLayoutUnit/Point/Rect to LayoutUnit/Point/Rect when ...
alan
Reported 2019-12-07 14:12:21 PST
Implicit floor will do for now (when going from float -> LayoutUnit)
Attachments
Patch (10.86 KB, patch)
2019-12-07 14:20 PST, alan
sam: review+
Radar WebKit Bug Importer
Comment 1 2019-12-07 14:13:13 PST
alan
Comment 2 2019-12-07 14:20:03 PST
Sam Weinig
Comment 3 2019-12-07 16:53:11 PST
Comment on attachment 385106 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385106&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:229 > + LayoutRect rect = Layout::toLayoutRect(run.logicalRect()); Auto?
alan
Comment 4 2019-12-07 19:00:29 PST
(In reply to Sam Weinig from comment #3) > Comment on attachment 385106 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385106&action=review > > > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:229 > > + LayoutRect rect = Layout::toLayoutRect(run.logicalRect()); > > Auto? oh right!
alan
Comment 5 2019-12-07 19:00:30 PST
Note You need to log in before you can comment on or make changes to this bug.