Bug 204982 - [LFC][Integration] Layout test assert and crash fixes
Summary: [LFC][Integration] Layout test assert and crash fixes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-07 02:59 PST by Antti Koivisto
Modified: 2019-12-07 05:57 PST (History)
10 users (show)

See Also:

Attachments
patch (7.38 KB, patch)
2019-12-07 03:06 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (7.68 KB, patch)
2019-12-07 03:10 PST, Antti Koivisto 		zalan: review+
Details | Formatted Diff | Diff
patch (7.68 KB, patch)
2019-12-07 05:30 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-12-07 02:59:18 PST 
Fixes for common integration related assertion failures with LFC enabled.
Comment 1 Antti Koivisto 2019-12-07 03:06:22 PST 
Created attachment 385089 [details]
patch
Comment 2 Antti Koivisto 2019-12-07 03:10:07 PST 
Created attachment 385090 [details]
patch
Comment 3 zalan 2019-12-07 04:39:32 PST 
Comment on attachment 385090 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385090&action=review

> Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:197
> +            childLayoutBox = makeUnique<Box>(elementAttributes(renderer), RenderStyle::clone(renderer.style()));

lol
Comment 4 Antti Koivisto 2019-12-07 05:30:26 PST 
Created attachment 385095 [details]
patch
Comment 5 WebKit Commit Bot 2019-12-07 05:56:59 PST 
Comment on attachment 385095 [details]
patch

Clearing flags on attachment: 385095

Committed r253251: <https://trac.webkit.org/changeset/253251>
Comment 6 WebKit Commit Bot 2019-12-07 05:57:00 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-07 05:57:19 PST 
<rdar://problem/57727271>