Bug 204980 - Change adoptNode() for a DocumentFragment with host
Summary: Change adoptNode() for a DocumentFragment with host
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2019-12-07 01:09 PST by Anne van Kesteren
Modified: 2022-10-23 23:46 PDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anne van Kesteren 2019-12-07 01:09:08 PST
See https://github.com/whatwg/dom/pull/754 and https://github.com/web-platform-tests/wpt/pull/16348. In particular, you'll need to return early from adoptNode() if the DocumentFragment has a host (and is not a shadow root).
Comment 1 Radar WebKit Bug Importer 2019-12-07 13:17:54 PST
<rdar://problem/57730074>
Comment 2 Anne van Kesteren 2020-03-30 06:14:08 PDT
Unfortunately the initial fix was not quite correct. There's a new fix up at https://github.com/whatwg/dom/pull/819 that I'd appreciate review on.
Comment 3 Ryosuke Niwa 2022-07-02 14:52:53 PDT
Pull request: https://github.com/WebKit/WebKit/pull/2034
Comment 4 EWS 2022-07-02 21:41:41 PDT
Committed 252098@main (ab3c0b8cf2a4): <https://commits.webkit.org/252098@main>

Reviewed commits have been landed. Closing PR #2034 and removing active labels.