Bug 204978 – Unique origin's window must get its own event loop

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Right now, they share the same event loop, this is wrong.

[Ryosuke Niwa]

Created attachment 385092 [details]
Fixes the bug

[Antti Koivisto]

Comment on attachment 385092 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=385092&action=review

> Source/WebCore/dom/WindowEventLoop.cpp:55
> +        return String();

Could just say 
return { };

> Source/WebCore/dom/WindowEventLoop.cpp:63
> +        return create(String());

Similarly
return create({ });

[Ryosuke Niwa]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 385092 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385092&action=review
> 
> > Source/WebCore/dom/WindowEventLoop.cpp:55
> > +        return String();
> 
> Could just say 
> return { };

Fixed.

> > Source/WebCore/dom/WindowEventLoop.cpp:63
> > +        return create(String());
> 
> Similarly
> return create({ });

Fixed.

[Ryosuke Niwa]

Thanks for the review!

[Ryosuke Niwa]

Committed r253265: <https://trac.webkit.org/changeset/253265>

[Radar WebKit Bug Importer]

<rdar://problem/57731204>