Bug 204978 - Unique origin's window must get its own event loop
Summary: Unique origin's window must get its own event loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 204492
  Show dependency treegraph
 
Reported: 2019-12-06 23:37 PST by Ryosuke Niwa
Modified: 2019-12-07 16:42 PST (History)
10 users (show)

See Also:


Attachments
Fixes the bug (22.83 KB, patch)
2019-12-07 03:31 PST, Ryosuke Niwa
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-12-06 23:37:45 PST
Right now, they share the same event loop, this is wrong.
Comment 1 Ryosuke Niwa 2019-12-07 03:31:29 PST
Created attachment 385092 [details]
Fixes the bug
Comment 2 Antti Koivisto 2019-12-07 06:26:55 PST
Comment on attachment 385092 [details]
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=385092&action=review

> Source/WebCore/dom/WindowEventLoop.cpp:55
> +        return String();

Could just say 
return { };

> Source/WebCore/dom/WindowEventLoop.cpp:63
> +        return create(String());

Similarly
return create({ });
Comment 3 Ryosuke Niwa 2019-12-07 16:35:20 PST
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 385092 [details]
> Fixes the bug
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=385092&action=review
> 
> > Source/WebCore/dom/WindowEventLoop.cpp:55
> > +        return String();
> 
> Could just say 
> return { };

Fixed.

> > Source/WebCore/dom/WindowEventLoop.cpp:63
> > +        return create(String());
> 
> Similarly
> return create({ });

Fixed.
Comment 4 Ryosuke Niwa 2019-12-07 16:35:28 PST
Thanks for the review!
Comment 5 Ryosuke Niwa 2019-12-07 16:41:05 PST
Committed r253265: <https://trac.webkit.org/changeset/253265>
Comment 6 Radar WebKit Bug Importer 2019-12-07 16:42:23 PST
<rdar://problem/57731204>