Bug 204969 - Turn on TestWebKitAPI.WKAttachmentTests.CopyAndPasteBetweenWebViews as it is now passing again.
Summary: Turn on TestWebKitAPI.WKAttachmentTests.CopyAndPasteBetweenWebViews as it is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-06 18:04 PST by Megan Gardner
Modified: 2021-08-19 15:32 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2019-12-06 18:06 PST, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (1.82 KB, patch)
2020-03-17 11:20 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (1.85 KB, patch)
2021-08-17 17:35 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2019-12-06 18:04:42 PST 
Turn on TestWebKitAPI.WebKit2CustomProtocolsTest.CloseDuringCustomProtocolLoad as it is now passing again.
Comment 1 Megan Gardner 2019-12-06 18:06:08 PST 
Created attachment 385073 [details]
Patch
Comment 2 Wenson Hsieh 2019-12-06 19:52:50 PST 
<rdar://problem/51752593>
Comment 3 Wenson Hsieh 2019-12-06 19:53:20 PST 
Comment on attachment 385073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385073&action=review

> Tools/ChangeLog:3
> +        Turn on TestWebKitAPI.WebKit2CustomProtocolsTest.CloseDuringCustomProtocolLoad as it is now passing again.

Nit - WKAttachmentTests.CopyAndPasteBetweenWebViews?
Comment 4 Alexey Proskuryakov 2019-12-07 13:19:27 PST 
Comment on attachment 385073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385073&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:-1493
> -#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MAX_ALLOWED < 130000

EWS says that it's still failing :(
Comment 5 Megan Gardner 2020-03-17 11:20:42 PDT 
Created attachment 393769 [details]
Patch
Comment 6 Alexey Proskuryakov 2020-05-06 10:00:12 PDT 
It still failed with the latest patch.
Comment 7 Megan Gardner 2021-08-17 17:35:17 PDT 
Created attachment 435730 [details]
Patch
Comment 8 EWS 2021-08-19 15:32:56 PDT 
Committed r281275 (240700@main): <https://commits.webkit.org/240700@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 435730 [details].