On macOS and iOS, it should be possible to add regression tests for blocked mach services.
rdar://problem/57414291
Created attachment 385054 [details] Patch
Created attachment 385058 [details] Patch
Comment on attachment 385058 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385058&action=review > Source/WebCore/ChangeLog:9 > + to Internals, which checks whether the WebContent process has access to mach lookup for a given global Good idea! I do not see why this should be limited to WebContent - sandbox_check can check other processes too. May be worth adding a universal method right away.
Created attachment 385167 [details] Patch
(In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 385058 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385058&action=review > > > Source/WebCore/ChangeLog:9 > > + to Internals, which checks whether the WebContent process has access to mach lookup for a given global > > Good idea! I do not see why this should be limited to WebContent - > sandbox_check can check other processes too. May be worth adding a universal > method right away. Credits go to Geoff and Darin :) I have added a process name parameter to the method. Thanks for reviewing!
Comment on attachment 385167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385167&action=review > Source/WebCore/testing/Internals.cpp:5337 > + if (process == "com.apple.WebKit.WebContent") What about WebContent.Development?
(In reply to Brent Fulgham from comment #7) > Comment on attachment 385167 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385167&action=review > > > Source/WebCore/testing/Internals.cpp:5337 > > + if (process == "com.apple.WebKit.WebContent") > > What about WebContent.Development? This string will be passed from the layout test html file, and will be the same for both debug and release builds, so I don't think we need to include a check for WebContent.Development in this case. Thanks for reviewing!
Comment on attachment 385167 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385167&action=review R=me >>> Source/WebCore/testing/Internals.cpp:5337 >>> + if (process == "com.apple.WebKit.WebContent") >> >> What about WebContent.Development? > > This string will be passed from the layout test html file, and will be the same for both debug and release builds, so I don't think we need to include a check for WebContent.Development in this case. > > Thanks for reviewing! Very good!
(In reply to Brent Fulgham from comment #9) > Comment on attachment 385167 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385167&action=review > > R=me > > >>> Source/WebCore/testing/Internals.cpp:5337 > >>> + if (process == "com.apple.WebKit.WebContent") > >> > >> What about WebContent.Development? > > > > This string will be passed from the layout test html file, and will be the same for both debug and release builds, so I don't think we need to include a check for WebContent.Development in this case. > > > > Thanks for reviewing! > > Very good! Thanks for reviewing :)
Comment on attachment 385167 [details] Patch Clearing flags on attachment: 385167 Committed r253353: <https://trac.webkit.org/changeset/253353>
All reviewed patches have been landed. Closing bug.