Bug 204952 - Python 3: Add support in webkitpy.test
Summary: Python 3: Add support in webkitpy.test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-06 11:13 PST by Jonathan Bedard
Modified: 2019-12-06 14:46 PST (History)
8 users (show)

See Also:

Attachments
Patch (25.62 KB, patch)
2019-12-06 11:25 PST, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2019-12-06 11:13:08 PST 
This will allow us to run test-webkitpy with Python3.

Note that this change does not guarantee that all tests actually pass when running in Python 3, just that we can run the harness. I'm going to keep the existing Python 3 harness until all the tests are passing.
Comment 1 Jonathan Bedard 2019-12-06 11:25:31 PST 
Created attachment 385029 [details]
Patch
Comment 2 Stephanie Lewis 2019-12-06 13:42:22 PST 
Comment on attachment 385029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385029&action=review

> Source/WebKit/Scripts/webkit/messages_unittest.py:31
> +    from StringIO import StringIO

Why not use Unicode compact function here?
Comment 3 Jonathan Bedard 2019-12-06 13:48:45 PST 
Comment on attachment 385029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385029&action=review

>> Source/WebKit/Scripts/webkit/messages_unittest.py:31
>> +    from StringIO import StringIO
> 
> Why not use Unicode compact function here?

Because this file has no webkitpy dependencies, we don't want to introduce one.
Comment 4 WebKit Commit Bot 2019-12-06 14:45:45 PST 
Comment on attachment 385029 [details]
Patch

Clearing flags on attachment: 385029

Committed r253219: <https://trac.webkit.org/changeset/253219>
Comment 5 WebKit Commit Bot 2019-12-06 14:45:46 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-12-06 14:46:20 PST 
<rdar://problem/57714030>