Bug 204945 - Support different resolutions for video tracks captured from UIProcess
Summary: Support different resolutions for video tracks captured from UIProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-06 05:01 PST by youenn fablet
Modified: 2019-12-09 09:21 PST (History)
14 users (show)

See Also:

Attachments
Patch (24.56 KB, patch)
2019-12-06 05:08 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (29.79 KB, patch)
2019-12-06 07:48 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (24.67 KB, patch)
2019-12-06 09:03 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (24.70 KB, patch)
2019-12-08 08:08 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-12-06 05:01:29 PST 
Support different resolutions for video tracks captured from UIProcess
Comment 1 youenn fablet 2019-12-06 05:08:59 PST 
Created attachment 385006 [details]
Patch
Comment 2 youenn fablet 2019-12-06 07:48:29 PST 
Created attachment 385012 [details]
Patch
Comment 3 youenn fablet 2019-12-06 09:03:54 PST 
Created attachment 385019 [details]
Patch
Comment 4 Eric Carlson 2019-12-06 09:47:49 PST 
Comment on attachment 385019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=385019&action=review

> Source/WebCore/platform/mediastream/RealtimeVideoCaptureSource.cpp:404
> +        if (m_imageTransferSession) {

It is probably worth logging if m_imageTransferSession is NULL at this point.
Comment 5 Eric Carlson 2019-12-06 09:48:18 PST 
Very nice!
Comment 6 youenn fablet 2019-12-08 08:08:43 PST 
Created attachment 385122 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2019-12-08 11:10:10 PST 
Comment on attachment 385122 [details]
Patch for landing

Clearing flags on attachment: 385122

Committed r253275: <https://trac.webkit.org/changeset/253275>
Comment 8 WebKit Commit Bot 2019-12-08 11:10:12 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-12-08 11:11:35 PST 
<rdar://problem/57735210>
Comment 10 Jonathan Bedard 2019-12-09 09:02:28 PST 
Pretty confident this caused a layout test regression on Mac:

https://results.webkit.org/?suite=layout-tests&test=fast%2Fmediastream%2Fmediastreamtrack-video-clone.html&platform=mac
Comment 11 youenn fablet 2019-12-09 09:21:54 PST 
See https://bugs.webkit.org/show_bug.cgi?id=205006