Bug 204927 - Fix WebGL conformance test build_177_to_178.html with USE_ANGLE
Summary: Fix WebGL conformance test build_177_to_178.html with USE_ANGLE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on:
Blocks: webglangle
  Show dependency treegraph
 
Reported: 2019-12-05 16:07 PST by James Darpinian
Modified: 2020-03-11 17:12 PDT (History)
9 users (show)

See Also:


Attachments
Fix WebGL conformance test build_177_to_178.html with USE_ANGLE (1.85 KB, patch)
2019-12-05 16:10 PST, James Darpinian
no flags Details | Formatted Diff | Diff
Don't disable extension for compileShaderDirect (2.13 KB, patch)
2019-12-05 16:15 PST, James Darpinian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2019-12-05 16:07:32 PST
Fix WebGL conformance test build_177_to_178.html with USE_ANGLE
Comment 1 James Darpinian 2019-12-05 16:10:24 PST
Created attachment 384972 [details]
Fix WebGL conformance test build_177_to_178.html with USE_ANGLE
Comment 2 James Darpinian 2019-12-05 16:15:10 PST
Created attachment 384973 [details]
Don't disable extension for compileShaderDirect
Comment 3 Kenneth Russell 2019-12-06 16:56:44 PST
LGTM but I'm not a reviewer.

Dean, Alex, possible to get your review of this?
Comment 4 Dean Jackson 2019-12-17 13:27:55 PST
Comment on attachment 384973 [details]
Don't disable extension for compileShaderDirect

View in context: https://bugs.webkit.org/attachment.cgi?id=384973&action=review

> Source/WebCore/platform/graphics/angle/GraphicsContext3DANGLE.cpp:-822
> -    compileShader(shader);

Hopefully this method will go away soon (with an ANGLE backend)
Comment 5 WebKit Commit Bot 2019-12-17 15:17:53 PST
Comment on attachment 384973 [details]
Don't disable extension for compileShaderDirect

Clearing flags on attachment: 384973

Committed r253652: <https://trac.webkit.org/changeset/253652>
Comment 6 WebKit Commit Bot 2019-12-17 15:17:55 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-17 15:18:30 PST
<rdar://problem/58023728>