Bug 204908 - Add ThreadMessageReceiver to IPC::Connection
Summary: Add ThreadMessageReceiver to IPC::Connection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-05 13:29 PST by Sihui Liu
Modified: 2019-12-05 15:30 PST (History)
4 users (show)

See Also:

Attachments
Patch (7.67 KB, patch)
2019-12-05 13:35 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (7.89 KB, patch)
2019-12-05 15:08 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-12-05 13:29:54 PST 
...
Comment 1 Sihui Liu 2019-12-05 13:35:25 PST 
Created attachment 384939 [details]
Patch
Comment 2 Brady Eidson 2019-12-05 14:15:55 PST 
Comment on attachment 384939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384939&action=review

It's weird to be adding dead code, but I happen to know it's in prep for https://bugs.webkit.org/show_bug.cgi?id=203690

To make sure everybody knows, please reference in the ChangeLog

> Source/WebKit/Platform/IPC/Connection.h:341
> +    Lock m_threadMessageReceiversMutex;

It's a lock, not a mutex. Let's name it as such.
Comment 3 Chris Dumez 2019-12-05 14:22:24 PST 
Comment on attachment 384939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384939&action=review

> Source/WebKit/ChangeLog:7
> +

Please add a change log!
Comment 4 Sihui Liu 2019-12-05 15:08:01 PST 
Created attachment 384966 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-12-05 15:29:05 PST 
Comment on attachment 384966 [details]
Patch for landing

Clearing flags on attachment: 384966

Committed r253177: <https://trac.webkit.org/changeset/253177>
Comment 6 WebKit Commit Bot 2019-12-05 15:29:06 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-05 15:30:35 PST 
<rdar://problem/57679992>