Bug 204900 - IndexedDB: pass along error of IDBBackingStore::renameIndex
Summary: IndexedDB: pass along error of IDBBackingStore::renameIndex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-05 10:39 PST by Sihui Liu
Modified: 2019-12-06 15:57 PST (History)
6 users (show)

See Also:

Attachments
Patch (4.55 KB, patch)
2019-12-05 11:10 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (7.34 KB, patch)
2019-12-05 12:13 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2019-12-05 10:39:11 PST 
...
Comment 1 Sihui Liu 2019-12-05 11:10:19 PST 
Created attachment 384923 [details]
Patch
Comment 2 Sihui Liu 2019-12-05 12:13:07 PST 
Created attachment 384932 [details]
Patch
Comment 3 Brady Eidson 2019-12-05 14:17:18 PST 
Comment on attachment 384932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384932&action=review

> Source/WebCore/ChangeLog:13
> +        Covered by existing test: storage/indexeddb//modern/index-rename-1-private.html

I don't see any changes to that test or its expectations, yet this is purportedly a behavior change.

How is it covered by the test?
Comment 4 Sihui Liu 2019-12-05 14:34:05 PST 
(In reply to Brady Eidson from comment #3)
> Comment on attachment 384932 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384932&action=review
> 
> > Source/WebCore/ChangeLog:13
> > +        Covered by existing test: storage/indexeddb//modern/index-rename-1-private.html
> 
> I don't see any changes to that test or its expectations, yet this is
> purportedly a behavior change.
> 
> How is it covered by the test?

The two bugs are covered by the test after we pass along the IDBBackingStore error.
Comment 5 WebKit Commit Bot 2019-12-06 15:56:42 PST 
Comment on attachment 384932 [details]
Patch

Clearing flags on attachment: 384932

Committed r253228: <https://trac.webkit.org/changeset/253228>
Comment 6 WebKit Commit Bot 2019-12-06 15:56:43 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-06 15:57:22 PST 
<rdar://problem/57716666>