RESOLVED FIXED 204885
[LFC][IFC] Many render tree dump tests show 1px too narrow runs 
https://bugs.webkit.org/show_bug.cgi?id=204885
Summary [LFC][IFC] Many render tree dump tests show 1px too narrow runs
Antti Koivisto
Reported 2019-12-05 05:28:21 PST
We are losing precisions when converting measured widths to LayoutUnits.
Attachments
patch (2.08 KB, patch)
2019-12-05 05:36 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-12-05 05:36:27 PST
Created attachment 384899 [details] patch
zalan
Comment 2 2019-12-05 06:43:29 PST
Comment on attachment 384899 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=384899&action=review > Source/WebCore/layout/inlineformatting/text/TextUtil.cpp:74 > + return std::max(0_lu, LayoutUnit::fromFloatRound(width)); Please add a some words here so that it's clear why we do this random (and presumably temporary) rounding. So I guess the reason why SLL uses float everywhere is to match ComplexLineLayout results. This is very unfortunate and probably fails over time with accumulated rounding. I wish we could essentiallyEqual the layout tests the same way LayoutContext::verifyAndOutputMismatchingLayoutTree does. :(
WebKit Commit Bot
Comment 3 2019-12-05 09:11:26 PST
Comment on attachment 384899 [details] patch Clearing flags on attachment: 384899 Committed r253151: <https://trac.webkit.org/changeset/253151>
WebKit Commit Bot
Comment 4 2019-12-05 09:11:28 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-12-05 09:12:20 PST
<rdar://problem/57665768>
Note You need to log in before you can comment on or make changes to this bug.