Fix a broken assertion in GetByStatus::computeForStubInfoWithoutExitSiteFeedback().

[Mark Lam]

The assertion wrong assumes that access.offset() cannot be invalid unless the access.type() is a Miss.  However, if the AccessCase is a Custom value or accessor, the offset is always invalid.  We'll fix the assertion.

[Mark Lam]

Created attachment 384868 [details]
proposed patch.

[Saam Barati]

Comment on attachment 384868 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=384868&action=review

> Source/JavaScriptCore/bytecode/GetByStatus.cpp:295
> +                ASSERT(access.isCustom() || ((AccessCase::Miss == access.type()) == (access.offset() == invalidOffset)));

you could also do:
ASSERT(((AccessCase::Miss == access.type() || access.isCustom()) == (access.offset() == invalidOffset)));

[Mark Lam]

(In reply to Saam Barati from comment #2)
> you could also do:
> ASSERT(((AccessCase::Miss == access.type() || access.isCustom()) ==
> (access.offset() == invalidOffset)));

Thanks for the review.  I've applied this change.

Landed in r253136: <http://trac.webkit.org/r253136>.

[Radar WebKit Bug Importer]

<rdar://problem/57648868>