Bug 204858 - Resource Load Statistics (experimental): Add fast mode for non-cookie website data deletion
Summary: Resource Load Statistics (experimental): Add fast mode for non-cookie website...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-04 13:45 PST by John Wilander
Modified: 2019-12-05 16:26 PST (History)
4 users (show)

See Also:

Attachments
Patch (19.48 KB, patch)
2019-12-05 12:48 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Patch for landing (19.46 KB, patch)
2019-12-05 15:56 PST, John Wilander 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2019-12-04 13:45:35 PST 
We need a significantly shorter timeout than 7 days for testing purposes.
Comment 1 Radar WebKit Bug Importer 2019-12-04 13:47:04 PST 
<rdar://problem/57639851>
Comment 2 John Wilander 2019-12-05 12:48:14 PST 
Created attachment 384936 [details]
Patch
Comment 3 Alex Christensen 2019-12-05 15:02:24 PST 
Comment on attachment 384936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384936&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1822
> -  defaultValue: false
> +  defaultValue: true

Was this change intentional?
Comment 4 John Wilander 2019-12-05 15:04:14 PST 
(In reply to Alex Christensen from comment #3)
> Comment on attachment 384936 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384936&action=review
> 
> > Source/WebKit/Shared/WebPreferences.yaml:1822
> > -  defaultValue: false
> > +  defaultValue: true
> 
> Was this change intentional?

Yes, I mention it in the change log:
"This change changes the default value of IsFirstPartyWebsiteDataRemovalEnabled to true."

The reason is that the related patch landed with it off by default so that we could decide on a test setup before turning it on. This patch is the test setup.
Comment 5 John Wilander 2019-12-05 15:56:57 PST 
Created attachment 384971 [details]
Patch for landing
Comment 6 John Wilander 2019-12-05 15:57:27 PST 
Thanks, Alex! I found a stray newline and deleted it.
Comment 7 WebKit Commit Bot 2019-12-05 16:26:16 PST 
Comment on attachment 384971 [details]
Patch for landing

Clearing flags on attachment: 384971

Committed r253185: <https://trac.webkit.org/changeset/253185>
Comment 8 WebKit Commit Bot 2019-12-05 16:26:18 PST 
All reviewed patches have been landed.  Closing bug.