RESOLVED FIXED 204852
[LFC][Integration] Paint with TextPainter 
https://bugs.webkit.org/show_bug.cgi?id=204852
Summary [LFC][Integration] Paint with TextPainter
Antti Koivisto
Reported 2019-12-04 08:06:48 PST
Paint with correct text properties.
Attachments
patch (11.52 KB, patch)
2019-12-04 08:13 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (11.52 KB, patch)
2019-12-04 08:15 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (11.52 KB, patch)
2019-12-04 08:16 PST, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (11.47 KB, patch)
2019-12-04 09:16 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2019-12-04 08:13:34 PST
Created attachment 384810 [details] patch
Antti Koivisto
Comment 2 2019-12-04 08:15:18 PST
Created attachment 384811 [details] patch
Antti Koivisto
Comment 3 2019-12-04 08:16:58 PST
Created attachment 384812 [details] patch
zalan
Comment 4 2019-12-04 08:50:32 PST
Comment on attachment 384812 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=384812&action=review > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:188 > + if (textContext.start() == textContext.end()) !textContext.length() > Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp:196 > + LayoutRect rect = run.logicalRect(); > + FloatRect visualOverflowRect = computeOverflow(style, rect, viewportSize); why no auto? (also in a few places further down)
Antti Koivisto
Comment 5 2019-12-04 09:16:44 PST
Created attachment 384819 [details] patch
WebKit Commit Bot
Comment 6 2019-12-04 10:00:43 PST
Comment on attachment 384819 [details] patch Clearing flags on attachment: 384819 Committed r253107: <https://trac.webkit.org/changeset/253107>
WebKit Commit Bot
Comment 7 2019-12-04 10:00:44 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-12-04 10:01:23 PST
<rdar://problem/57627529>
Note You need to log in before you can comment on or make changes to this bug.