Bug 204847 – Add support for WebIDL set-like forEach

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Add support for WebIDL set-like forEach

[youenn fablet]

Created attachment 384823 [details]
Patch

[youenn fablet]

 inspector/debugger/tail-deleted-frames/tail-deleted-frames-this-value.html is failing in Mac-debug-wk1, not Mac-wk1, so probably is fine.

[youenn fablet]

Created attachment 384993 [details]
Patch

[Megan Gardner]

Comment on attachment 384993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384993&action=review

This is not my area, but lgtm, but we should probably get Chris or Darin or someone else to review this as well...

> Source/WebCore/bindings/js/JSDOMBindingInternals.js:39
> +    @getByIdDirectPrivate(this, "backingSet").forEach((value, key, map) => {

map? should this be 'set'?

> LayoutTests/platform/mac-wk1/TestExpectations:34
> +

I'm confused how this was affected at all

[youenn fablet]

> > Source/WebCore/bindings/js/JSDOMBindingInternals.js:39
> > +    @getByIdDirectPrivate(this, "backingSet").forEach((value, key, map) => {
> 
> map? should this be 'set'?

Right, sounds better, should not change the behaviour.

> > LayoutTests/platform/mac-wk1/TestExpectations:34
> > +
> 
> I'm confused how this was affected at all

I don't know either, I asked Joe and Devin and apparently this depends on which methods are executed or not before or as part of the test.

If I remove the JS-built-in for the setlike foreach, the test passes again.
Maybe the test should be rewritten to be more robust.

[youenn fablet]

Created attachment 385123 [details]
Patch

[youenn fablet]

Created attachment 385136 [details]
Patch

[youenn fablet]

Comment on attachment 385136 [details]
Patch

Worked around the inspector test failure by making the JS builtin working for both setlike and maplike.

[youenn fablet]

ping review

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 385136 [details]:

imported/w3c/web-platform-tests/content-security-policy/reporting/report-same-origin-with-cookies.html bug 205216 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 385136 [details]
Patch

Clearing flags on attachment: 385136

Committed r253494: <https://trac.webkit.org/changeset/253494>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57921779>