This supports running webkit-patch with Python 3.
Created attachment 384788 [details] Patch
Comment on attachment 384788 [details] Patch Clearing flags on attachment: 384788 Committed r253128: <https://trac.webkit.org/changeset/253128>
All reviewed patches have been landed. Closing bug.
<rdar://problem/57645975>
Reopening to attach new patch.
Created attachment 384910 [details] Patch
Created attachment 384911 [details] Patch
(In reply to Jonathan Bedard from comment #7) > Created attachment 384911 [details] > Patch Tried uploading a patch with Python 3, hit a few bumps. This is what I needed for webkit-patch upload.
Comment on attachment 384911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384911&action=review > Tools/Scripts/webkit-patch:45 > +# If our str type isn't unicode, we need to standardize output format why remove all the comments?
(In reply to Stephanie Lewis from comment #9) > Comment on attachment 384911 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384911&action=review > > > Tools/Scripts/webkit-patch:45 > > +# If our str type isn't unicode, we need to standardize output format > > why remove all the comments? I can put them back, but they weren't super helpful and not applicable to Python 3. We're likely going to be removing them once we are only Python 3 anyways.
Comment on attachment 384911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384911&action=review >>> Tools/Scripts/webkit-patch:45 >>> +# If our str type isn't unicode, we need to standardize output format >> >> why remove all the comments? > > I can put them back, but they weren't super helpful and not applicable to Python 3. We're likely going to be removing them once we are only Python 3 anyways. I think Saying why 2.7 needs a forgiving utf8 writer is important to explain why this class exists. And the bug number this code is solving is useful too
Created attachment 385040 [details] Patch
(In reply to Stephanie Lewis from comment #11) > Comment on attachment 384911 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384911&action=review > > >>> Tools/Scripts/webkit-patch:45 > >>> +# If our str type isn't unicode, we need to standardize output format > >> > >> why remove all the comments? > > > > I can put them back, but they weren't super helpful and not applicable to Python 3. We're likely going to be removing them once we are only Python 3 anyways. > > I think Saying why 2.7 needs a forgiving utf8 writer is important to explain > why this class exists. And the bug number this code is solving is useful too Ok, added back in the comments.
Comment on attachment 385040 [details] Patch Clearing flags on attachment: 385040 Committed r253222: <https://trac.webkit.org/changeset/253222>
Committed r253230: <https://trac.webkit.org/changeset/253230>