Bug 204838 – Python 3: Add support in webkitpy.tool

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

This supports running webkit-patch with Python 3.

[Jonathan Bedard]

Created attachment 384788 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 384788 [details]
Patch

Clearing flags on attachment: 384788

Committed r253128: <https://trac.webkit.org/changeset/253128>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57645975>

[Jonathan Bedard]

Reopening to attach new patch.

[Jonathan Bedard]

Created attachment 384910 [details]
Patch

[Jonathan Bedard]

Created attachment 384911 [details]
Patch

[Jonathan Bedard]

(In reply to Jonathan Bedard from comment #7)
> Created attachment 384911 [details]
> Patch

Tried uploading a patch with Python 3, hit a few bumps. This is what I needed for webkit-patch upload.

[Stephanie Lewis]

Comment on attachment 384911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384911&action=review

> Tools/Scripts/webkit-patch:45
> +# If our str type isn't unicode, we need to standardize output format

why remove all the comments?

[Jonathan Bedard]

(In reply to Stephanie Lewis from comment #9)
> Comment on attachment 384911 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384911&action=review
> 
> > Tools/Scripts/webkit-patch:45
> > +# If our str type isn't unicode, we need to standardize output format
> 
> why remove all the comments?

I can put them back, but they weren't super helpful and not applicable to Python 3. We're likely going to be removing them once we are only Python 3 anyways.

[Stephanie Lewis]

Comment on attachment 384911 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384911&action=review

>>> Tools/Scripts/webkit-patch:45
>>> +# If our str type isn't unicode, we need to standardize output format
>> 
>> why remove all the comments?
> 
> I can put them back, but they weren't super helpful and not applicable to Python 3. We're likely going to be removing them once we are only Python 3 anyways.

I think Saying why 2.7 needs a forgiving utf8 writer is important to explain why this class exists. And the bug number this code is solving  is useful too

[Jonathan Bedard]

Created attachment 385040 [details]
Patch

[Jonathan Bedard]

(In reply to Stephanie Lewis from comment #11)
> Comment on attachment 384911 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384911&action=review
> 
> >>> Tools/Scripts/webkit-patch:45
> >>> +# If our str type isn't unicode, we need to standardize output format
> >> 
> >> why remove all the comments?
> > 
> > I can put them back, but they weren't super helpful and not applicable to Python 3. We're likely going to be removing them once we are only Python 3 anyways.
> 
> I think Saying why 2.7 needs a forgiving utf8 writer is important to explain
> why this class exists. And the bug number this code is solving  is useful too

Ok, added back in the comments.

[WebKit Commit Bot]

Comment on attachment 385040 [details]
Patch

Clearing flags on attachment: 385040

Committed r253222: <https://trac.webkit.org/changeset/253222>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jonathan Bedard]

Committed r253230: <https://trac.webkit.org/changeset/253230>