Bug 204837 - Remove unused DragController::client()
Summary: Remove unused DragController::client()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-03 21:27 PST by Daniel Bates
Modified: 2019-12-03 22:31 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2019-12-03 21:29 PST, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-12-03 21:27:29 PST 
Quick authoring check shows that DragController::client() has never been used since its inception in <http://trac.webkit.org/r19039>. Moreover, it exposes DragController internals, which diminishes its encapsulation capabilities.
Comment 1 Daniel Bates 2019-12-03 21:29:46 PST 
Created attachment 384787 [details]
Patch
Comment 2 Daniel Bates 2019-12-03 22:30:25 PST 
Comment on attachment 384787 [details]
Patch

Clearing flags on attachment: 384787

Committed r253094: <https://trac.webkit.org/changeset/253094>
Comment 3 Daniel Bates 2019-12-03 22:30:27 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-12-03 22:31:20 PST 
<rdar://problem/57615121>