WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
204810
[bmalloc] Decommit unused region in chunk metadata.
https://bugs.webkit.org/show_bug.cgi?id=204810
Summary
[bmalloc] Decommit unused region in chunk metadata.
Basuke Suzuki
Reported
2019-12-03 13:08:06 PST
In chunk metadata region, there are unused memory region which we can safely decommit them at the Chunk initialization.
Attachments
PATCH
(1.67 KB, patch)
2019-12-03 13:23 PST
,
Basuke Suzuki
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Basuke Suzuki
Comment 1
2019-12-03 13:09:14 PST
Based on the investigation on
https://bugs.webkit.org/show_bug.cgi?id=204773#c3
. We can simply decommit unused pages before doing such big change.
Basuke Suzuki
Comment 2
2019-12-03 13:10:50 PST
testmem score is almost same or a little bit better, but in error range. before: end score: 8.5654 MB peak score: 8.8361 MB total memory score: 8.6997 MB time score: 668.57 ms after: end score: 8.5237 MB peak score: 8.7828 MB total memory score: 8.6523 MB time score: 667.35 ms
Basuke Suzuki
Comment 3
2019-12-03 13:23:49 PST
Created
attachment 384746
[details]
PATCH
Yusuke Suzuki
Comment 4
2019-12-06 23:58:06 PST
Comment on
attachment 384746
[details]
PATCH Given how we are executing scavenger, it would be profitable.
WebKit Commit Bot
Comment 5
2019-12-07 00:42:56 PST
Comment on
attachment 384746
[details]
PATCH Clearing flags on attachment: 384746 Committed
r253245
: <
https://trac.webkit.org/changeset/253245
>
WebKit Commit Bot
Comment 6
2019-12-07 00:42:58 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2019-12-07 00:43:19 PST
<
rdar://problem/57725438
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug