Bug 204792 - WebProcessPool::terminateServiceWorkerProcess should be renamed terminateServiceWorkers
Summary: WebProcessPool::terminateServiceWorkerProcess should be renamed terminateServ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-03 05:49 PST by youenn fablet
Modified: 2019-12-04 06:17 PST (History)
4 users (show)

See Also:

Attachments
Patch (17.02 KB, patch)
2019-12-03 05:52 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (17.03 KB, patch)
2019-12-04 03:53 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-12-03 05:49:26 PST 
WebProcessPool::terminateServiceWorkerProcess should be renamed terminateServiceWorker since that is what it should do.
Comment 1 youenn fablet 2019-12-03 05:52:34 PST 
Created attachment 384709 [details]
Patch
Comment 2 Chris Dumez 2019-12-03 11:49:57 PST 
Comment on attachment 384709 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384709&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:-1733
> -    auto protectedThis = makeRef(*this);

Why drop this? Seems safer to protect ourselves as we iterate.
Comment 3 youenn fablet 2019-12-04 03:53:05 PST 
Created attachment 384803 [details]
Patch for landing
Comment 4 youenn fablet 2019-12-04 05:33:00 PST 
(In reply to Chris Dumez from comment #2)
> Comment on attachment 384709 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384709&action=review
> 
> > Source/WebKit/UIProcess/WebProcessPool.cpp:-1733
> > -    auto protectedThis = makeRef(*this);
> 
> Why drop this? Seems safer to protect ourselves as we iterate.

I kept it.
Comment 5 WebKit Commit Bot 2019-12-04 06:16:28 PST 
Comment on attachment 384803 [details]
Patch for landing

Clearing flags on attachment: 384803

Committed r253103: <https://trac.webkit.org/changeset/253103>
Comment 6 WebKit Commit Bot 2019-12-04 06:16:30 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-04 06:17:22 PST 
<rdar://problem/57622520>