RESOLVED FIXED 204792
WebProcessPool::terminateServiceWorkerProcess should be renamed terminateServiceWorkers 
https://bugs.webkit.org/show_bug.cgi?id=204792
Summary WebProcessPool::terminateServiceWorkerProcess should be renamed terminateServ...
youenn fablet
Reported 2019-12-03 05:49:26 PST
WebProcessPool::terminateServiceWorkerProcess should be renamed terminateServiceWorker since that is what it should do.
Attachments
Patch (17.02 KB, patch)
2019-12-03 05:52 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (17.03 KB, patch)
2019-12-04 03:53 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-12-03 05:52:34 PST
Created attachment 384709 [details] Patch
Chris Dumez
Comment 2 2019-12-03 11:49:57 PST
Comment on attachment 384709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384709&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:-1733 > - auto protectedThis = makeRef(*this); Why drop this? Seems safer to protect ourselves as we iterate.
youenn fablet
Comment 3 2019-12-04 03:53:05 PST
Created attachment 384803 [details] Patch for landing
youenn fablet
Comment 4 2019-12-04 05:33:00 PST
(In reply to Chris Dumez from comment #2) > Comment on attachment 384709 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384709&action=review > > > Source/WebKit/UIProcess/WebProcessPool.cpp:-1733 > > - auto protectedThis = makeRef(*this); > > Why drop this? Seems safer to protect ourselves as we iterate. I kept it.
WebKit Commit Bot
Comment 5 2019-12-04 06:16:28 PST
Comment on attachment 384803 [details] Patch for landing Clearing flags on attachment: 384803 Committed r253103: <https://trac.webkit.org/changeset/253103>
WebKit Commit Bot
Comment 6 2019-12-04 06:16:30 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-12-04 06:17:22 PST
<rdar://problem/57622520>
Note You need to log in before you can comment on or make changes to this bug.