WebProcessPool::terminateServiceWorkerProcess should be renamed terminateServiceWorker since that is what it should do.
Created attachment 384709 [details] Patch
Comment on attachment 384709 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384709&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:-1733 > - auto protectedThis = makeRef(*this); Why drop this? Seems safer to protect ourselves as we iterate.
Created attachment 384803 [details] Patch for landing
(In reply to Chris Dumez from comment #2) > Comment on attachment 384709 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384709&action=review > > > Source/WebKit/UIProcess/WebProcessPool.cpp:-1733 > > - auto protectedThis = makeRef(*this); > > Why drop this? Seems safer to protect ourselves as we iterate. I kept it.
Comment on attachment 384803 [details] Patch for landing Clearing flags on attachment: 384803 Committed r253103: <https://trac.webkit.org/changeset/253103>
All reviewed patches have been landed. Closing bug.
<rdar://problem/57622520>