RESOLVED FIXED 204786
UserMediaCaptureManager should have independent capture factories 
https://bugs.webkit.org/show_bug.cgi?id=204786
Summary UserMediaCaptureManager should have independent capture factories
youenn fablet
Reported 2019-12-03 01:51:13 PST
UserMediaCaptureManager should have independent capture factories
Attachments
Patch (12.14 KB, patch)
2019-12-03 01:54 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (12.17 KB, patch)
2019-12-03 06:14 PST, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2019-12-03 01:54:13 PST
Created attachment 384698 [details] Patch
Eric Carlson
Comment 2 2019-12-03 05:55:33 PST
Comment on attachment 384698 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384698&action=review > Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:101 > + case CaptureDevice::DeviceType::Unknown: Nit: this should ASSERT_NOT_REACHED as the constructor does.
youenn fablet
Comment 3 2019-12-03 06:14:29 PST
Created attachment 384710 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-12-03 11:08:04 PST
The commit-queue encountered the following flaky tests while processing attachment 384710 [details]: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit.html bug 204800 (author: cdumez@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2019-12-03 11:08:47 PST
Comment on attachment 384710 [details] Patch for landing Clearing flags on attachment: 384710 Committed r253055: <https://trac.webkit.org/changeset/253055>
WebKit Commit Bot
Comment 6 2019-12-03 11:08:48 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-12-03 11:09:20 PST
<rdar://problem/57596043>
Note You need to log in before you can comment on or make changes to this bug.