Bug 204786 - UserMediaCaptureManager should have independent capture factories
Summary: UserMediaCaptureManager should have independent capture factories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-03 01:51 PST by youenn fablet
Modified: 2019-12-03 11:09 PST (History)
9 users (show)

See Also:


Attachments
Patch (12.14 KB, patch)
2019-12-03 01:54 PST, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (12.17 KB, patch)
2019-12-03 06:14 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-12-03 01:51:13 PST
UserMediaCaptureManager should have independent capture factories
Comment 1 youenn fablet 2019-12-03 01:54:13 PST
Created attachment 384698 [details]
Patch
Comment 2 Eric Carlson 2019-12-03 05:55:33 PST
Comment on attachment 384698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384698&action=review

> Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp:101
> +        case CaptureDevice::DeviceType::Unknown:

Nit: this should ASSERT_NOT_REACHED as the constructor does.
Comment 3 youenn fablet 2019-12-03 06:14:29 PST
Created attachment 384710 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2019-12-03 11:08:04 PST
The commit-queue encountered the following flaky tests while processing attachment 384710 [details]:

imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit.html bug 204800 (author: cdumez@apple.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2019-12-03 11:08:47 PST
Comment on attachment 384710 [details]
Patch for landing

Clearing flags on attachment: 384710

Committed r253055: <https://trac.webkit.org/changeset/253055>
Comment 6 WebKit Commit Bot 2019-12-03 11:08:48 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-12-03 11:09:20 PST
<rdar://problem/57596043>