Bug 204785 – Web Inspector: add WI.EngineeringSetting and WI.DebugSetting to avoid callsite checking

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

We have lots of `WI.isEngineeringBuild && WI.settings.engineering___.value` anywhere we need to use engineering settings (similar case for debug settings), when in reality the callsites really don't need to be concerned with this logic.  Ideally, they'd just get the engineering/debug setting's value and the value getter itself would know whether to use the actual value or the default value based on `WI.isEngineeringBuild`/`WI.isDebugUIEnabled`.

[Devin Rousso]

Created attachment 384691 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 384691 [details]
Patch

Rejecting attachment 384691 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 384691, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=384691&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=204785&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 384691 from bug 204785.
Fetching: https://bugs.webkit.org/attachment.cgi?id=384691
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 17 diffs from patch file(s).
patching file Source/WebInspectorUI/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebInspectorUI/UserInterface/Base/Main.js
patching file Source/WebInspectorUI/UserInterface/Base/Setting.js
patching file Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js
patching file Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js
patching file Source/WebInspectorUI/UserInterface/Controllers/DiagnosticController.js
patching file Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js
patching file Source/WebInspectorUI/UserInterface/Models/CSSProperty.js
patching file Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js
patching file Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js
patching file Source/WebInspectorUI/UserInterface/Proxies/HeapSnapshotEdgeProxy.js
patching file Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js
Hunk #1 FAILED at 434.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js.rej
patching file Source/WebInspectorUI/UserInterface/Views/HeapSnapshotDataGridTree.js
patching file Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.js
patching file Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
patching file Source/WebInspectorUI/UserInterface/Views/StackTraceView.js
Hunk #1 succeeded at 35 with fuzz 1.
patching file Source/WebInspectorUI/UserInterface/Views/View.js

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Timothy Hatcher']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/13287084

[Devin Rousso]

Created attachment 384947 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 384947 [details]
Patch

Clearing flags on attachment: 384947

Committed r253172: <https://trac.webkit.org/changeset/253172>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57678300>

[Joseph Pecoraro]

Nice!