Bug 204780 - PageConfiguration::pluginClient should use a smart pointer
Summary: PageConfiguration::pluginClient should use a smart pointer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-02 19:01 PST by Chris Dumez
Modified: 2019-12-03 10:18 PST (History)
7 users (show)

See Also:

Attachments
Patch (7.42 KB, patch)
2019-12-02 19:03 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (7.38 KB, patch)
2019-12-03 09:39 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-12-02 19:01:51 PST 
PageConfiguration::pluginClient should use a smart pointer.
Comment 1 Chris Dumez 2019-12-02 19:03:21 PST 
Created attachment 384678 [details]
Patch
Comment 2 Anders Carlsson 2019-12-03 08:47:59 PST 
Comment on attachment 384678 [details]
Patch

Odd that WebKitLegacy doesn't use PlugInClient at all.
Comment 3 Chris Dumez 2019-12-03 09:39:36 PST 
Created attachment 384718 [details]
Patch
Comment 4 WebKit Commit Bot 2019-12-03 10:17:45 PST 
Comment on attachment 384718 [details]
Patch

Clearing flags on attachment: 384718

Committed r253051: <https://trac.webkit.org/changeset/253051>
Comment 5 WebKit Commit Bot 2019-12-03 10:17:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-12-03 10:18:20 PST 
<rdar://problem/57594110>