Bug 204778 – run-jsc should exit with the same signal or exit status that the `jsc` shell does

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

...

[Saam Barati]

Created attachment 384677 [details]
patch

[Keith Miller]

Comment on attachment 384677 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384677&action=review

r=me

> Tools/Scripts/run-jsc:70
> +        system("kill -" . $signal . " " . $PID); # We kill ourselves with the same signal that the `jsc` process was killed with to make it look like `jsc` was directly invoked.

Beautiful!

[Saam Barati]

Comment on attachment 384677 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384677&action=review

>> Tools/Scripts/run-jsc:70
>> +        system("kill -" . $signal . " " . $PID); # We kill ourselves with the same signal that the `jsc` process was killed with to make it look like `jsc` was directly invoked.
> 
> Beautiful!

Thanks to your beautiful idea :-)

[WebKit Commit Bot]

Comment on attachment 384677 [details]
patch

Clearing flags on attachment: 384677

Committed r253024: <https://trac.webkit.org/changeset/253024>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/57580636>

[Ross Kirsling]

This patch seems to have introduced a strange result when exiting the shell.

Direct case:
> λ DYLD_FRAMEWORK_PATH=./WebKitBuild/Release ./WebKitBuild/Release/jsc --useDollarVM=1
> >>> <Ctrl+C>
>

Indirect case:
> λ Tools/Scripts/run-jsc
> Running 1 time(s): DYLD_FRAMEWORK_PATH=./WebKitBuild/Release ./WebKitBuild/Release/jsc --useDollarVM=1
> >>> <Ctrl+C>
> ... I should not be here ...
>

Obviously a cosmetic issue but it's weird to see every time I exit, hehe.

[Saam Barati]

(In reply to Ross Kirsling from comment #7)
> This patch seems to have introduced a strange result when exiting the shell.
> 
> Direct case:
> > λ DYLD_FRAMEWORK_PATH=./WebKitBuild/Release ./WebKitBuild/Release/jsc --useDollarVM=1
> > >>> <Ctrl+C>
> >
> 
> Indirect case:
> > λ Tools/Scripts/run-jsc
> > Running 1 time(s): DYLD_FRAMEWORK_PATH=./WebKitBuild/Release ./WebKitBuild/Release/jsc --useDollarVM=1
> > >>> <Ctrl+C>
> > ... I should not be here ...
> >
> 
> Obviously a cosmetic issue but it's weird to see every time I exit, hehe.

yeah, that's annoying...

Let me remove that.