Bug 204771 - [JSC] Put some destructible objects to IsoSubspace
Summary: [JSC] Put some destructible objects to IsoSubspace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-02 15:32 PST by Yusuke Suzuki
Modified: 2019-12-02 17:48 PST (History)
7 users (show)

See Also:

Attachments
Patch (58.61 KB, patch)
2019-12-02 15:38 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Patch (58.69 KB, patch)
2019-12-02 16:10 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-12-02 15:32:37 PST 
[JSC] Put some destructible objects to IsoSubspace
Comment 1 Yusuke Suzuki 2019-12-02 15:38:36 PST 
Created attachment 384664 [details]
Patch
Comment 2 Mark Lam 2019-12-02 16:01:24 PST 
Comment on attachment 384664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384664&action=review

r=me if tests pass.

> Source/JavaScriptCore/runtime/DateInstance.h:89
> +    JS_EXPORT_PRIVATE DateInstance(VM&, Structure*);
> +    void finishCreation(VM&);
> +    JS_EXPORT_PRIVATE void finishCreation(VM&, double);

nit: can you put these above the 2 calculate functions above.  I think we typically have the constructors come first.
Comment 3 Yusuke Suzuki 2019-12-02 16:08:11 PST 
Comment on attachment 384664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384664&action=review

>> Source/JavaScriptCore/runtime/DateInstance.h:89
>> +    JS_EXPORT_PRIVATE void finishCreation(VM&, double);
> 
> nit: can you put these above the 2 calculate functions above.  I think we typically have the constructors come first.

Sure, fixed.
Comment 4 Yusuke Suzuki 2019-12-02 16:10:09 PST 
Created attachment 384668 [details]
Patch

Patch for landing
Comment 5 Yusuke Suzuki 2019-12-02 17:47:41 PST 
Committed r253019: <https://trac.webkit.org/changeset/253019>
Comment 6 Radar WebKit Bug Importer 2019-12-02 17:48:21 PST 
<rdar://problem/57577848>