RESOLVED FIXED 204770
[iOS] Calls to the device motion API should be done in the UI process 
https://bugs.webkit.org/show_bug.cgi?id=204770
Summary [iOS] Calls to the device motion API should be done in the UI process
Per Arne Vollan
Reported 2019-12-02 15:09:19 PST
The device motion API on iOS is communicating with iohideventsystem. Since mach lookup to this daemon will be closed, the calls to this API should be moved from the WebContent process to the UI process.
Attachments
Patch (40.76 KB, patch)
2019-12-02 15:23 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (41.02 KB, patch)
2019-12-02 16:23 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (48.75 KB, patch)
2019-12-02 18:22 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (26.12 KB, patch)
2019-12-09 16:24 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (26.86 KB, patch)
2019-12-10 10:43 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-12-02 15:09:58 PST
<rdar://problem/57572913>
Per Arne Vollan
Comment 2 2019-12-02 15:23:33 PST
Created attachment 384662 [details] Patch
Per Arne Vollan
Comment 3 2019-12-02 16:23:14 PST
Created attachment 384670 [details] Patch
Per Arne Vollan
Comment 4 2019-12-02 18:22:58 PST
Created attachment 384673 [details] Patch
Per Arne Vollan
Comment 5 2019-12-09 16:24:20 PST
Created attachment 385207 [details] Patch
Per Arne Vollan
Comment 6 2019-12-10 10:43:59 PST
Created attachment 385285 [details] Patch
Brent Fulgham
Comment 7 2019-12-10 16:48:02 PST
Comment on attachment 385285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385285&action=review r=me, but please consider changing those bare pointers (perhaps even in a follow-up patch). > Source/WebCore/platform/ios/DeviceMotionClientIOS.h:55 > + DeviceMotionController* m_controller { nullptr }; I'm a little suspicious of these bare pointers. Could they be WeakPtrs?
Per Arne Vollan
Comment 8 2019-12-10 16:55:34 PST
(In reply to Brent Fulgham from comment #7) > Comment on attachment 385285 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385285&action=review > > r=me, but please consider changing those bare pointers (perhaps even in a > follow-up patch). > > > Source/WebCore/platform/ios/DeviceMotionClientIOS.h:55 > > + DeviceMotionController* m_controller { nullptr }; > > I'm a little suspicious of these bare pointers. Could they be WeakPtrs? I think they can be made WeakPtrs, I will look into that :) Thanks for reviewing!
Per Arne Vollan
Comment 9 2019-12-10 16:58:46 PST
(In reply to Brent Fulgham from comment #7) > Comment on attachment 385285 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=385285&action=review > > r=me, but please consider changing those bare pointers (perhaps even in a > follow-up patch). > > > Source/WebCore/platform/ios/DeviceMotionClientIOS.h:55 > > + DeviceMotionController* m_controller { nullptr }; > > I'm a little suspicious of these bare pointers. Could they be WeakPtrs? Filed https://bugs.webkit.org/show_bug.cgi?id=205093.
WebKit Commit Bot
Comment 10 2019-12-10 17:35:22 PST
Comment on attachment 385285 [details] Patch Clearing flags on attachment: 385285 Committed r253357: <https://trac.webkit.org/changeset/253357>
WebKit Commit Bot
Comment 11 2019-12-10 17:35:24 PST
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 12 2020-03-31 13:20:15 PDT
Comment on attachment 385285 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=385285&action=review > Source/WebCore/ChangeLog:3 > + [iOS] Calls to the device motion API should be done in the UI process This change seems to have badly broken the device motion API :( see <rdar://problem/60720953>.
Note You need to log in before you can comment on or make changes to this bug.