Bug 204765 - Adopt AVContentKeyReportGroup
Summary: Adopt AVContentKeyReportGroup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-02 13:47 PST by Jer Noble
Modified: 2019-12-03 15:05 PST (History)
3 users (show)

See Also:


Attachments
Patch (25.02 KB, patch)
2019-12-02 13:51 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (25.58 KB, patch)
2019-12-03 09:07 PST, Jer Noble
no flags Details | Formatted Diff | Diff
Patch for landing (25.57 KB, patch)
2019-12-03 13:37 PST, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2019-12-02 13:47:29 PST
Adopt AVContentKeyReportGroup
Comment 1 Jer Noble 2019-12-02 13:51:17 PST
Created attachment 384657 [details]
Patch
Comment 2 Jer Noble 2019-12-03 09:07:54 PST
Created attachment 384716 [details]
Patch
Comment 3 Eric Carlson 2019-12-03 11:09:30 PST
Comment on attachment 384716 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384716&action=review

> Source/WebCore/ChangeLog:11
> +        AVContentKeySession to continue working for platform versions without report group support.

"... existing usage of AVContentKeySession to continue working ..." isn't quite right. 

Maybe "... existing usage of AVContentKeySession continues to work ..."?

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:22955
> +				CD53555723748E5900A613BD /* MediaToolboxSoftLink.cpp */,
> +				CD53555623748E5900A613BD /* MediaToolboxSoftLink.h */,

Are these necessary?
Comment 4 Jer Noble 2019-12-03 13:28:34 PST
(In reply to Eric Carlson from comment #3)
> Comment on attachment 384716 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=384716&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        AVContentKeySession to continue working for platform versions without report group support.
> 
> "... existing usage of AVContentKeySession to continue working ..." isn't
> quite right. 
> 
> Maybe "... existing usage of AVContentKeySession continues to work ..."?

Sure.

> > Source/WebCore/WebCore.xcodeproj/project.pbxproj:22955
> > +				CD53555723748E5900A613BD /* MediaToolboxSoftLink.cpp */,
> > +				CD53555623748E5900A613BD /* MediaToolboxSoftLink.h */,
> 
> Are these necessary?

Only if you want to be able to open MediaToolboxSoftLink.{cpp,h} in Xcode. :)
Comment 5 Jer Noble 2019-12-03 13:37:57 PST
Created attachment 384750 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-12-03 15:04:05 PST
Comment on attachment 384750 [details]
Patch for landing

Clearing flags on attachment: 384750

Committed r253064: <https://trac.webkit.org/changeset/253064>
Comment 7 WebKit Commit Bot 2019-12-03 15:04:06 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-12-03 15:05:22 PST
<rdar://problem/57605017>