RESOLVED FIXED204765
Adopt AVContentKeyReportGroup 
https://bugs.webkit.org/show_bug.cgi?id=204765
Summary Adopt AVContentKeyReportGroup
Jer Noble
Reported 2019-12-02 13:47:29 PST
Adopt AVContentKeyReportGroup
Attachments
Patch (25.02 KB, patch)
2019-12-02 13:51 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (25.58 KB, patch)
2019-12-03 09:07 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (25.57 KB, patch)
2019-12-03 13:37 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2019-12-02 13:51:17 PST
Created attachment 384657 [details] Patch
Jer Noble
Comment 2 2019-12-03 09:07:54 PST
Created attachment 384716 [details] Patch
Eric Carlson
Comment 3 2019-12-03 11:09:30 PST
Comment on attachment 384716 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=384716&action=review > Source/WebCore/ChangeLog:11 > + AVContentKeySession to continue working for platform versions without report group support. "... existing usage of AVContentKeySession to continue working ..." isn't quite right. Maybe "... existing usage of AVContentKeySession continues to work ..."? > Source/WebCore/WebCore.xcodeproj/project.pbxproj:22955 > + CD53555723748E5900A613BD /* MediaToolboxSoftLink.cpp */, > + CD53555623748E5900A613BD /* MediaToolboxSoftLink.h */, Are these necessary?
Jer Noble
Comment 4 2019-12-03 13:28:34 PST
(In reply to Eric Carlson from comment #3) > Comment on attachment 384716 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=384716&action=review > > > Source/WebCore/ChangeLog:11 > > + AVContentKeySession to continue working for platform versions without report group support. > > "... existing usage of AVContentKeySession to continue working ..." isn't > quite right. > > Maybe "... existing usage of AVContentKeySession continues to work ..."? Sure. > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:22955 > > + CD53555723748E5900A613BD /* MediaToolboxSoftLink.cpp */, > > + CD53555623748E5900A613BD /* MediaToolboxSoftLink.h */, > > Are these necessary? Only if you want to be able to open MediaToolboxSoftLink.{cpp,h} in Xcode. :)
Jer Noble
Comment 5 2019-12-03 13:37:57 PST
Created attachment 384750 [details] Patch for landing
WebKit Commit Bot
Comment 6 2019-12-03 15:04:05 PST
Comment on attachment 384750 [details] Patch for landing Clearing flags on attachment: 384750 Committed r253064: <https://trac.webkit.org/changeset/253064>
WebKit Commit Bot
Comment 7 2019-12-03 15:04:06 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-12-03 15:05:22 PST
<rdar://problem/57605017>
Note You need to log in before you can comment on or make changes to this bug.