Bug 204727 - [LFC][Render tree] Support LFC in LineLayoutTraversal
Summary: [LFC][Render tree] Support LFC in LineLayoutTraversal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-12-01 07:54 PST by Antti Koivisto
Modified: 2019-12-02 01:30 PST (History)
14 users (show)

See Also:

Attachments
wip (45.99 KB, patch)
2019-12-01 07:58 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (47.96 KB, patch)
2019-12-01 12:21 PST, Antti Koivisto 		zalan: review+
Details | Formatted Diff | Diff
patch (48.25 KB, patch)
2019-12-02 00:07 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-12-01 07:54:53 PST 
This allows render tree dumps, TextIterator etc. work with LFC inline layout.
Comment 1 Antti Koivisto 2019-12-01 07:58:44 PST 
Created attachment 384572 [details]
wip
Comment 2 Antti Koivisto 2019-12-01 12:21:36 PST 
Created attachment 384578 [details]
patch
Comment 3 zalan 2019-12-01 12:57:20 PST 
Comment on attachment 384578 [details]
patch

Let's fix some of the naming in a separate patch. Will try to figure out something.
Comment 4 zalan 2019-12-01 20:55:37 PST 
How about if we manage to move LineBox over to Display namespace the "results" could simply be something like Display::InlineContent
Comment 5 Antti Koivisto 2019-12-02 00:07:35 PST 
Created attachment 384595 [details]
patch
Comment 6 Antti Koivisto 2019-12-02 00:08:28 PST 
(In reply to zalan from comment #4)
> How about if we manage to move LineBox over to Display namespace the
> "results" could simply be something like Display::InlineContent

I made it Display::InlineContent. LineBox still needs moving.
Comment 7 WebKit Commit Bot 2019-12-02 01:29:06 PST 
Comment on attachment 384595 [details]
patch

Clearing flags on attachment: 384595

Committed r252979: <https://trac.webkit.org/changeset/252979>
Comment 8 WebKit Commit Bot 2019-12-02 01:29:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-12-02 01:30:20 PST 
<rdar://problem/57552905>