Bug 204717 - [Web Animations] Calling reverse() on an accelerated animation has no effect
Summary: [Web Animations] Calling reverse() on an accelerated animation has no effect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL: https://jsfiddle.net/birtles/zcjgvfy2...
Keywords: InRadar
: 188841 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-11-30 09:09 PST by Antoine Quint
Modified: 2020-05-13 12:27 PDT (History)
14 users (show)

See Also:


Attachments
Patch (31.29 KB, patch)
2020-05-13 06:49 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-11-30 09:09:52 PST
If you go to https://jsfiddle.net/birtles/zcjgvfy2/22/ and press "counter-clockwise", the animation runs clockwise. I didn't check to be sure, but I believe the call to reverse() has no effect on the accelerated animation.
Comment 1 interalia.dev 2020-04-28 01:55:41 PDT
This works properly in Firefox and Chrome. Still doesn't work in both latest Safari and TP.
Comment 2 Radar WebKit Bug Importer 2020-04-28 03:18:47 PDT
<rdar://problem/62503582>
Comment 3 Antoine Quint 2020-04-28 09:28:11 PDT
I think there are two issues here:

1. we don't reflect the animation's playback rate for accelerated animations
2. we don't reflect changes to timing properties while an accelerated animation is already running
Comment 4 Antoine Quint 2020-04-28 11:33:12 PDT
*** Bug 188841 has been marked as a duplicate of this bug. ***
Comment 5 Antoine Quint 2020-05-13 06:34:59 PDT
For now the approach will be to bail if we're trying to animate something with playbackRate != 1. We'll try to use CA animations for that case in bug 211839.
Comment 6 Antoine Quint 2020-05-13 06:49:12 PDT
Created attachment 399257 [details]
Patch
Comment 7 EWS 2020-05-13 12:27:02 PDT
Committed r261637: <https://trac.webkit.org/changeset/261637>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399257 [details].