Bug 204702 - Add mechanism for enabling internal and experimental features from run-webkit-test command line
Summary: Add mechanism for enabling internal and experimental features from run-webkit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-29 07:56 PST by Antti Koivisto
Modified: 2019-12-02 13:23 PST (History)
9 users (show)

See Also:


Attachments
patch (8.01 KB, patch)
2019-11-29 09:10 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-11-29 07:56:07 PST
Add a flag to run existing tests with LFC enabled.
Comment 1 Antti Koivisto 2019-11-29 09:10:46 PST
Created attachment 384511 [details]
patch
Comment 2 WebKit Commit Bot 2019-11-29 10:54:24 PST
Comment on attachment 384511 [details]
patch

Clearing flags on attachment: 384511

Committed r252948: <https://trac.webkit.org/changeset/252948>
Comment 3 WebKit Commit Bot 2019-11-29 10:54:25 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-11-29 10:55:21 PST
<rdar://problem/57534243>
Comment 5 Jonathan Bedard 2019-12-02 09:01:37 PST
Generally in favor of this, a few comments.

1st, this should probably apply to run-api-tests too.

2nd, we should consider what effect this will have when reporting results, if we intend to run queues with these flags (and I think we should be doing this, I know there is an intention to with a few features in the recent future). We should probably have this flag automatically set the configuration ‘flavor’ which is supposed to be the dumping ground for this sort of thing.
Comment 6 Antti Koivisto 2019-12-02 13:23:13 PST
> 2nd, we should consider what effect this will have when reporting results,
> if we intend to run queues with these flags (and I think we should be doing
> this, I know there is an intention to with a few features in the recent
> future). We should probably have this flag automatically set the
> configuration ‘flavor’ which is supposed to be the dumping ground for this
> sort of thing.

This was meant for engineers developing features, I didn't consider using it in infrastructure.