Bug 204698 - Reimplement some PlatformCALayer methods using GraphicsContext instead of CGContextRef
Summary: Reimplement some PlatformCALayer methods using GraphicsContext instead of CGC...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-11-29 03:48 PST by Tim Horton
Modified: 2019-11-30 17:07 PST (History)
6 users (show)

See Also:


Attachments
Patch (26.48 KB, patch)
2019-11-29 03:49 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (27.34 KB, patch)
2019-11-29 13:57 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (27.37 KB, patch)
2019-11-29 14:03 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (28.25 KB, patch)
2019-11-29 16:57 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (28.52 KB, patch)
2019-11-30 16:24 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2019-11-29 03:48:54 PST
Reimplement some PlatformCALayer methods using GraphicsContext instead of CGContextRef
Comment 1 Tim Horton 2019-11-29 03:49:21 PST
Created attachment 384494 [details]
Patch
Comment 2 Tim Horton 2019-11-29 13:57:25 PST
Created attachment 384523 [details]
Patch
Comment 3 Tim Horton 2019-11-29 14:03:54 PST
Created attachment 384525 [details]
Patch
Comment 4 Tim Horton 2019-11-29 16:57:42 PST
Created attachment 384533 [details]
Patch
Comment 5 Sam Weinig 2019-11-30 06:56:40 PST
Comment on attachment 384533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=384533&action=review

> Source/WebCore/platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:1239
> +void PlatformCALayerCocoa::enumerateRectsBeingDrawn(GraphicsContext& context, void (^block)(CGRect))

Seems like block should probably take a FloatRect.
Comment 6 Tim Horton 2019-11-30 16:24:13 PST
Created attachment 384556 [details]
Patch
Comment 7 WebKit Commit Bot 2019-11-30 17:06:57 PST
Comment on attachment 384556 [details]
Patch

Clearing flags on attachment: 384556

Committed r252962: <https://trac.webkit.org/changeset/252962>
Comment 8 WebKit Commit Bot 2019-11-30 17:06:59 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-11-30 17:07:16 PST
<rdar://problem/57541634>